Re: [PATCH] gnu: Add tracker.

[iyzsong@member.fsf.org (宋文武)]

rennes@openmailbox.org writes:

> On 2016-02-06 23:28, Leo Famulari wrote:
>> On Sat, Feb 06, 2016 at 09:47:22PM +0100, rennes@openmailbox.org wrote:
>>> Hi,
>>>
>>> i attached patch with new variable(tracker) for gnome.scm.
>>>
>>> Tracker, is a search engine and metadata storage system used for
>>> nautilus(gnome file manager).
>>>
>>> The steps i follow are:
>>>
>>>  a) I edit gnu/packages/gnome.scm and added tracker variable.
>>>  b) git add gnu/packages/gnome.scm
>>>  c) git commit -m 'gnu: Add tracker.'
>> 
>>    Don't forget:
>>    c′) ./pre-inst-env guix lint tracker
>> 
>>>  d) git format-patch -1
>>   
>> [...]
>> 
>>> * gnu/packages/gnome.scm (tracker): New variable.
>> 
>> Okay.
>> 
>>> +    (arguments
>>> +     ;; Testsuite finishes with errors.
>>> +     `(#:configure-flags '("--enable-unit-tests=no")))
>> 
>> Are these failures important? Are they caused by the unusual Guix build
>> environment? If so, can you disable only the specific tests that are
>> failing?
>> 
>> Otherwise, I wait for the input of a GNOME / GTK expert :)
>> 
>>> +    (native-inputs
>>> +     `(("glib" ,glib) ; for glib-compile-schemas, gio-2.0.
Should be ("glib:bin" ,glib "bin"), `,glib "bin"` mean use the "bin"
output of the glib package, and "glib:bin" is a name for this input,
name is not important, but we usually use that.

>>> +       ("intltool" ,intltool)
>>> +       ("pkg-config" ,pkg-config)))
>>> +    (inputs
>>> +     `(("gobject-introspection" ,gobject-introspection)
>>> +       ("libpng" ,libpng)
>>> +       ("libunistring" ,libunistring)
>>> +       ("libxml2" ,libxml2)
>>> +       ("sqlite" ,sqlite)
>>> +       ("uuidgen" ,util-linux)
>>> +       ("xsltproc" ,libxslt)
>>> +       ("zlib" ,zlib)))
I think gobject-introspection, uuidgen and xsltproc should move to
native-inputs if they are only used during build phases\.
You can check that after build with `guix size tracker' to see if
those inputs are still in the closure.

>>> +    (home-page "https://wiki.gnome.org/Projects/Tracker")
>>> +    (synopsis "Search engine and metadata storage system")
>>> +    (description
>>> +     "Tracker is a search engine, search tool and metadata storage
>>> +system.  Tracker allows the user to find their data as fast as possible.
>>> +Tracker organises data in categories and enable tag in the data with
>>> +keywords which can be used to find related information.")
For GNOME projects, which have detailed doap file, I prefer synopsis and
description from upstream:

https://git.gnome.org/browse/tracker/tree/tracker.doap

>>> +    ;; See COPYING for details.
>>> +    (license (list license:lgpl2.1+ license:gpl2+ license:bsd-3))))
>>> --
>>> 2.6.3
>>>
>
> Thanks Leo,
>
> the errors during Testsuite are:
>
> ERROR: tracker-utils - missing test plan
> ERROR: tracker-utils - exited with status 133 (terminated by signal
> 5?)
> PASS: tracker-dbus 1 /libtracker-common/tracker-dbus/slist_to_strv_ok
> PASS: tracker-dbus 2
> /libtracker-common/tracker-dbus/slist_to_strv_failures
> PASS: tracker-dbus 3 /libtracker-common/tracker-dbus/request
> ERROR: tracker-file-utils - missing test plan
> ERROR: tracker-file-utils - exited with status 133 (terminated by
> signal 5?)
>
> Testsuite summary for tracker 1.7.2
>
> # TOTAL: 68
> # PASS: 42
> # SKIP: 22
> # XFAIL: 0
> # FAIL: 0
> # XPASS: 0
> # ERROR: 4
>
> I can`t see more details.
The log files (test-suite.log or *.log) should have more details,
you can build with 'guix build -K tracker' to keep the directory,
and look the log files.