From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [RFCv4] install: Create a GC root during install-grub.
Date: Sun, 13 Mar 2016 22:44:38 +0100
Message-ID: <87a8m2vyrd.fsf@gnu.org>
References: <56d7a6b8.8391700a.87f3c.ffffa7fe@mx.google.com>
	<56e2689e.890bc30a.12110.3cc0@mx.google.com> <878u1pyss9.fsf@gnu.org>
	<20160311162327.GA28593@novena-choice-citizen.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59386)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1afDoc-0008O9-Hp
	for guix-devel@gnu.org; Sun, 13 Mar 2016 17:44:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1afDoX-0007Q9-Gl
	for guix-devel@gnu.org; Sun, 13 Mar 2016 17:44:46 -0400
In-Reply-To: <20160311162327.GA28593@novena-choice-citizen.lan> (Jookia's
	message of "Sat, 12 Mar 2016 03:23:27 +1100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Jookia <166291@gmail.com>
Cc: guix-devel@gnu.org

Jookia <166291@gmail.com> skribis:

> On Fri, Mar 11, 2016 at 03:48:38PM +0100, Ludovic Court=C3=A8s wrote:
>> Jookia <166291@gmail.com> skribis:
>>=20
>> > While previously creating a GC root for GRUB's resources was the calle=
r's
>> > responsibility, it's much less repetitive to put it in install-grub no=
w that
>> > it's wrapped by error handling. This also means we can replace the ins=
tall-grub*
>> > function with a small definition inside perform-action named 'install-=
boot'.
>> >
>> > * gnu/build/install.scm (install-grub): Make a GC root for grub.cfg on=
 success.
>> >   (register-grub.cfg-root): Remove function, install-grub does this no=
w.
>> > * gnu/system/vm.scm (qemu-image): Don't explicitly make a GC root.
>> > * guix/scripts/system.scm (install-grub*): Move useful parts to perfor=
m-action.
>> >   (perform-action): Use inline definition install-boot to install GRUB.
>>=20
>> Is it different from v1 to v3?
>>=20
>> I=E2=80=99m asking because I feel it might be difficult for me to find o=
ut what
>> the right version is when I start reviewing these.  :-)
>>=20
>> Ludo=E2=80=99.
>
> Yes, apologies since I'm not exactly sure how to add text that would be t=
aken
> out in final patches. v2 fixes an issue with reconfigure breaking since it
> assumed there was always a target (not true), I can't remember what v3 fi=
xed, v4
> fixed v2's fix since I used the wrong variable name.=20

OK.

> Perhaps I should write diffs to patches assuming all the patches are
> in a single directory?

Diffs to patches would be hard to read, but if you could simply add a
cover letter with a short summary of the changes compared to previous
versions, that=E2=80=99d be perfect.  :-)

Ludo=E2=80=99.