unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "alírio eyng" <alirioeyng@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: font-gnu-freefont-ttf: Update to 20120503 and build from source.
Date: Thu, 31 Mar 2016 09:48:53 +0200	[thread overview]
Message-ID: <87a8lfdr4q.fsf@gnu.org> (raw)
In-Reply-To: <CALkz57FZ1bVDtZXr-LKVdVMcEtSN=1uONtoikfOP+su=8d7nVg@mail.gmail.com> ("alírio eyng"'s message of "Tue, 29 Mar 2016 03:38:04 +0000")

alírio eyng <alirioeyng@gmail.com> skribis:

>>> * gnu/packages/fonts.scm (font-gnu-freefont-ttf): Update to 20120503.
>>> [arguments]: Build from source.
>>> * guix/gnu-maintenance.scm (%tarball-rx): Remove comment.
>> Not clear, how about “Remove comment about freefont-ttf.”?
> ok
>>> […]
>>> +    (native-inputs `(("fontforge" ,(package (inherit fontforge)
>>> +                                     (inputs `(("python-2" ,python-2)
>>> +                                     ,@(package-inputs fontforge)))))))
>> Why not add ‘python-2’ to the fontforge package directly?
> see inline references in the updated patch
>
> From ab7a628f7d8fc9f68f0ebfdd27b3bcb32a607724 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?al=C3=ADrio=20eyng?= <alirioeyng@gmail.com>
> Date: Tue, 29 Mar 2016 03:32:58 +0000
> Subject: [PATCH] gnu: font-gnu-freefont-ttf: Update to 20120503 and build from
>  source.
>
> * gnu/packages/fonts.scm (font-gnu-freefont-ttf): Update to 20120503.
> [arguments]: Build from source.
> * guix/gnu-maintenance.scm (%tarball-rx): Remove comment about freefont-ttf.

[...]

> +    ;; https://github.com/fontforge/fontforge/pull/109
> +    ;;  "fontforge has to be compiled against only one python version"
> +    ;; https://github.com/fontforge/fontforge/issues/1731
> +    ;;  "default python version that fontforge links with is python 2"
> +    (native-inputs `(("fontforge" ,(package (inherit fontforge)
> +                                     (inputs `(("python-2" ,python-2)
> +                                     ,@(package-inputs fontforge)))))))

I understand cannot support Python 2 and 3 simultaneously, but I think
Leo was suggesting changing the ‘fontforge’ package to use Python 2.x
instead of 3.x.  WDYT?

Also, could you explain why we need fontforge-with-python2 instead of
fontforge-with-python3?

> diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
> index 9d720ca..eb9dcf8 100644
> --- a/guix/gnu-maintenance.scm
> +++ b/guix/gnu-maintenance.scm
> @@ -243,7 +243,6 @@ stored."
>      (substring tarball 0 end)))
>  
>  (define %tarball-rx
> -  ;; The .zip extensions is notably used for freefont-ttf.
>    ;; The "-src" pattern is for "TeXmacs-1.0.7.9-src.tar.gz".
>    ;; The "-gnu[0-9]" pattern is for "icecat-38.4.0-gnu1.tar.bz2".
>    (make-regexp "^([^.]+)-([0-9]|[^-])+(-(src|gnu[0-9]))?\\.(tar\\.|zip$)"))

This comment remains valid because there are .zip files in
ftp.gnu.org/gnu/freefont, so I think we should keep it.

Thanks, it’s a nice to have these fonts built from source!

Ludo’.

  reply	other threads:[~2016-03-31  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-26 14:47 [PATCH] gnu: font-gnu-freefont-ttf: Update to 20120503 and build from source alírio eyng
2016-03-28 13:40 ` 宋文武
2016-03-29  3:38   ` alírio eyng
2016-03-31  7:48     ` Ludovic Courtès [this message]
2016-03-31 13:18       ` alírio eyng
2016-03-31 21:45         ` Ludovic Courtès
2016-04-02  8:39         ` Eric Bavier
2016-04-02 10:38           ` alírio eyng
2016-04-03 21:47             ` Ludovic Courtès
2016-04-04 14:19               ` alírio eyng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8lfdr4q.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alirioeyng@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).