* [PATCH] Port Arrayfire to GNU Guix
@ 2016-03-20 2:28 Dennis Mungai
2016-04-04 21:18 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Dennis Mungai @ 2016-03-20 2:28 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
Hello,
The patch attached adds Arrayfire, a software library for GPU computing.
For compliance with the GPL licenses, I've configured the package not
to build with CUDA support, and the OpenCL backend builds with the
open source OpenCL ICD and the standard Khronos OpenCL headers for
vendor neutrality.
Thanks and regards,
Dennis
[-- Attachment #2: 0001-Ported-ArrayFire-to-GNU-Guix.patch --]
[-- Type: text/x-patch, Size: 14507 bytes --]
From c25732b9beb99a0788349c086f460d45f228dd74 Mon Sep 17 00:00:00 2001
From: Dennis Mungai <dmngaie@gmail.com>
Date: Sun, 20 Mar 2016 04:51:15 +0300
Subject: [PATCH] Ported ArrayFire to GNU Guix
---
arrayfire.scm | 362 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 362 insertions(+)
create mode 100644 arrayfire.scm
diff --git a/arrayfire.scm b/arrayfire.scm
new file mode 100644
index 0000000..c5326fa
--- /dev/null
+++ b/arrayfire.scm
@@ -0,0 +1,362 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Dennis Mungai <dmngaie@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gn packages arrayfire)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix download)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system cmake)
+ #:use-module (guix packages)
+ #:use-module (gnu packages)
+ #:use-module (guix utils)
+ #:use-module (gnu packages algebra)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages bootstrap)
+ #:use-module (gnu packages curl)
+ #:use-module (gnu packages gawk)
+ #:use-module (gnu packages cmake)
+ #:use-module (gnu packages boost)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages image)
+ #:use-module (gnu packages video)
+ #:use-module (gnu packages textutils)
+ #:use-module (gnu packages gl)
+ #:use-module (gnu packages gcc)
+ #:use-module (gnu packages gnupg)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages maths)
+ #:use-module (gnu packages mpi)
+ #:use-module (gnu packages web)
+ #:use-module (gnu packages wget)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages ruby)
+ #:use-module (gnu packages xorg)
+ #:use-module (gnu packages version-control)
+ #:use-module (gnu packages zip)
+ #:use-module (gnu packages linux))
+
+(define-public arrayfire
+(package
+ (name "arrayfire")
+ (version "3.3.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://arrayfire.com/arrayfire_source/arrayfire-full-" version
+ ".tar.bz2"))
+ (file-name (string-append name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "045adww6dqmyz6kkfmq7xawi5v9a894yp5j9pzn6j568gi48pyqc"))))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("gawk" ,gawk)
+ ("git" ,git)
+ ("glew" ,glew)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("boost" ,boost)
+ ("glfw" ,glfw)
+ ("compute" ,compute)
+ ("curl" ,curl)
+ ("clBLAS" ,clBLAS)
+ ("clFFT" ,clFFT)
+ ("atlas" ,atlas)
+ ("dbus" ,dbus)
+ ("opencl-headers" ,opencl-headers)
+ ("ocl-icd" ,ocl-icd)
+ ("enca" ,enca)
+ ("eudev" ,eudev)
+ ("glew" ,glew)
+ ("glib" ,glib)
+ ("lapack" ,lapack)
+ ("scalapack" ,scalapack)
+ ("libcap" ,libcap)
+ ("libjpeg" ,libjpeg)
+ ("libltdl" ,libltdl)
+ ("libtiff" ,libtiff)
+ ("libyajl" ,libyajl)
+ ("mesa-utils" ,mesa-utils)
+ ("python" ,python-2)
+ ("freeimage" ,freeimage)
+ ("freeglut" ,freeglut)
+ ("fftw" ,fftw)
+ ("fftwf" ,fftwf)
+ ("fftw-openmpi" ,fftw-openmpi)
+ ("glew" ,glew)
+ ("glu" ,glu)
+ ("openblas" ,openblas)
+ ("wget" ,wget)
+ ("cmake" ,cmake)))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DBUILD_OPENCL=ON" "-DBUILD_CUDA=OFF" "-DBUILD_GRAPHICS=OFF" "-DUSE_SYSTEM_BOOST_COMPUTE=ON" "-DUSE_SYSTEM_CLBLAS=ON" "-DUSE_SYSTEM_CLFFT=ON")
+ #:tests? #f))
+ (synopsis "ArrayFire: a general purpose GPU library. https://arrayfire.com")
+ (description "ArrayFire is a high performance software library for parallel computing with an easy-to-use API. Its array based function set makes parallel programming simple.Now on Guix")
+ (home-page "http://arrayfire.com/")
+ (license (list license:gpl2
+ license:gpl2+
+ license:gpl3
+ license:gpl3+))))
+
+(define-public glfw
+ (package
+ (name "glfw")
+ (version "3.1.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/glfw/glfw/archive/"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "08pixv8hd5xsccf7l8cqcijjqaq4k4da8qbp77wggal2fq445ika"))))
+ (build-system cmake-build-system)
+ (arguments `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")
+ #:tests? #f))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("cmake" ,cmake)
+ ("git" ,git)
+ ("libtool" ,libtool)
+ ("libpthread-stubs" ,libpthread-stubs)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("curl" ,curl)
+ ("dbus" ,dbus)
+ ("enca" ,enca)
+ ("eudev" ,eudev)
+ ("glew" ,glew)
+ ("libcap" ,libcap)
+ ("libjpeg" ,libjpeg)
+ ("libltdl" ,libltdl)
+ ("libtiff" ,libtiff)
+ ("mesa-utils" ,mesa-utils)
+ ("randrproto" ,randrproto)
+ ("libxrandr" ,libxrandr)
+ ("xineramaproto" ,xineramaproto)
+ ("libxinerama" ,libxinerama)
+ ("libxcursor" ,libxcursor)
+ ("python" ,python-2)))
+ (home-page "http://www.glfw.org/")
+ (synopsis "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (description "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (license (list license:gpl2))))
+
+(define-public clBLAS
+ (package
+ (name "clBLAS")
+ (version "v2.10")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/clMathLibraries/clBLAS/archive/"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0adlb02lqzrklfybhnv4n0p37mvkvdi3vqiwa05x2mv05ywnr93j"))))
+ (build-system cmake-build-system)
+ (arguments `(#:tests? #f
+ #:configure-flags '("../clBLAS-2.10/src" "-DBUILD_SHARED_LIBS=ON" "-DCMAKE_BUILD_TYPE=Release" "-DBUILD_TEST=OFF")))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("cmake" ,cmake)
+ ("gfortran" ,gfortran)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("curl" ,curl)
+ ("dbus" ,dbus)
+ ("boost" ,boost)
+ ("enca" ,enca)
+ ("eudev" ,eudev)
+ ("fftw-openmpi" ,fftw-openmpi)
+ ("glew" ,glew)
+ ("libcap" ,libcap)
+ ("libjpeg" ,libjpeg)
+ ("libltdl" ,libltdl)
+ ("libtiff" ,libtiff)
+ ("mesa-utils" ,mesa-utils)
+ ("openmpi" ,openmpi)
+ ("ocl-icd" ,ocl-icd)
+ ("opencl-headers" ,opencl-headers)
+ ("randrproto" ,randrproto)
+ ("libxrandr" ,libxrandr)
+ ("xineramaproto" ,xineramaproto)
+ ("libxinerama" ,libxinerama)
+ ("libxcursor" ,libxcursor)
+ ("python" ,python-2)))
+ (home-page "http://www.glfw.org/")
+ (synopsis "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (description "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (license (list license:gpl2))))
+
+(define-public clFFT
+ (package
+ (name "clFFT")
+ (version "v2.10.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/clMathLibraries/clFFT/archive/"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "19hrk1lf06kch8x9dpbdj0waycn2mldrmj2y4vzi7zn2gdfw6g73"))))
+ (build-system cmake-build-system)
+ (arguments `(#:configure-flags '("../clFFT-2.10.1/src" "-DBUILD_SHARED_LIBS=ON" "-DCMAKE_BUILD_TYPE=Release") #:tests? #f))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("cmake" ,cmake)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("curl" ,curl)
+ ("dbus" ,dbus)
+ ("enca" ,enca)
+ ("eudev" ,eudev)
+ ("fftw-openmpi" ,fftw-openmpi)
+ ("glew" ,glew)
+ ("libcap" ,libcap)
+ ("libjpeg" ,libjpeg)
+ ("libltdl" ,libltdl)
+ ("libtiff" ,libtiff)
+ ("mesa-utils" ,mesa-utils)
+ ("openmpi" ,openmpi)
+ ("ocl-icd" ,ocl-icd)
+ ("opencl-headers" ,opencl-headers)
+ ("randrproto" ,randrproto)
+ ("libxrandr" ,libxrandr)
+ ("xineramaproto" ,xineramaproto)
+ ("libxinerama" ,libxinerama)
+ ("libxcursor" ,libxcursor)
+ ("python" ,python-2)))
+ (home-page "http://www.glfw.org/")
+ (synopsis "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (description "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
+ (license (list license:gpl2))))
+
+(define-public compute
+ (package
+ (name "compute")
+ (version "v0.5")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/boostorg/compute/archive/"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1r16zd1wdnn9gx278mkvr13k3i79hr35v6vj0fn7v3n92ngwxnhd"))))
+ (build-system cmake-build-system)
+ (arguments `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON" "-DCMAKE_BUILD_TYPE=Release") #:tests? #f))
+ (native-inputs `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("cmake" ,cmake)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("curl" ,curl)
+ ("dbus" ,dbus)
+ ("enca" ,enca)
+ ("eudev" ,eudev)
+ ("fftw-openmpi" ,fftw-openmpi)
+ ("glew" ,glew)
+ ("boost" ,boost)
+ ("libcap" ,libcap)
+ ("libjpeg" ,libjpeg)
+ ("libltdl" ,libltdl)
+ ("libtiff" ,libtiff)
+ ("mesa-utils" ,mesa-utils)
+ ("openmpi" ,openmpi)
+ ("opencl-headers" ,opencl-headers)
+ ("ocl-icd" ,ocl-icd)
+ ("randrproto" ,randrproto)
+ ("libxrandr" ,libxrandr)
+ ("xineramaproto" ,xineramaproto)
+ ("libxinerama" ,libxinerama)
+ ("libxcursor" ,libxcursor)
+ ("python" ,python-2)))
+ (home-page "http://boost.org")
+ (synopsis "Peer-reviewed portable C++ source libraries,BoostCompute")
+ (description "Peer-reviewed portable C++ source libraries,BoostCompute")
+ (license (list license:x11-style))))
+
+(define-public ocl-icd
+ (package
+ (name "ocl-icd")
+ (version "2.2.9")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://forge.imag.fr/frs/download.php/716/ocl-icd-"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1rgaixwnxmrq2aq4kcdvs0yx7i6krakarya9vqs7qwsv5hzc32hc"))))
+ (inputs `(("zip" ,zip)
+ ("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("ruby" ,ruby)
+ ("libtool" ,libtool)
+ ("opencl-headers" ,opencl-headers)
+ ("libgcrypt" ,libgcrypt)))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases (modify-phases %standard-phases
+ (add-after 'unpack `bootstrap
+ (lambda _
+ (zero? (system* "autoreconf" "-vfi")))))))
+ (home-page "https://forge.imag.fr/projects/ocl-icd/")
+ (synopsis "OpenCL implementations are provided as ICD (Installable Client Driver).")
+ (description "OpenCL implementations are provided as ICD (Installable Client Driver).
+ An OpenCL program can use several ICD thanks to the use of an ICD Loader as provided by this project.
+ This free ICD Loader can load any (free or non free) ICD")
+ (license (list license:gpl2 license:ruby))))
+
+(define-public opencl-headers
+(let ((commit "c1770dc"))
+ (package
+ (name "opencl-headers")
+ (version (string-append "2.1-" commit ))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/KhronosGroup/OpenCL-Headers.git")
+ (commit commit)))
+ (file-name (string-append name "-" commit))
+ (sha256
+ (base32
+ "0m9fkblqja0686i2jjqiszvq3df95gp01a2674xknlmkd6525rck"))))
+ (propagated-inputs '())
+ (inputs '())
+ (native-inputs '())
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'build)
+ (delete 'check)
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (copy-recursively "." (string-append
+ (assoc-ref outputs "out")
+ "/include/CL")))))))
+ (synopsis "The Khronos OpenCL headers")
+ (description "This package provides the Khronos OpenCL headers")
+ (home-page "https://www.khronos.org/registry/cl/")
+ (license (list license:gpl2)))))
+
+
+
+
+
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Port Arrayfire to GNU Guix
2016-03-20 2:28 [PATCH] Port Arrayfire to GNU Guix Dennis Mungai
@ 2016-04-04 21:18 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2016-04-04 21:18 UTC (permalink / raw)
To: Dennis Mungai; +Cc: guix-devel
Hi,
Dennis Mungai <dmngaie@gmail.com> skribis:
> The patch attached adds Arrayfire, a software library for GPU computing.
> For compliance with the GPL licenses, I've configured the package not
> to build with CUDA support, and the OpenCL backend builds with the
> open source OpenCL ICD and the standard Khronos OpenCL headers for
> vendor neutrality.
Sorry for the late reply, and thanks for your work!
> From c25732b9beb99a0788349c086f460d45f228dd74 Mon Sep 17 00:00:00 2001
> From: Dennis Mungai <dmngaie@gmail.com>
> Date: Sun, 20 Mar 2016 04:51:15 +0300
> Subject: [PATCH] Ported ArrayFire to GNU Guix
>
> ---
> arrayfire.scm | 362 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Could you:
1. Send a patch against Guix ‘master’, where this file should be
called gnu/packages/opencl.scm? (I think ‘opencl’ is more
appropriate than ‘arrayfire’.)
2. Send one patch per package, to simply the review workflow?
3. Run ‘guix lint’ for each package and address any problems it raises
(hopefully simple to do, but feel free to ask for help on #guix).
4. Provide ChangeLog-style commit logs, as noted at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>?
That’s a bit of extra work, but it will really help us!
Some more specific comments:
> +(define-module (gn packages arrayfire)
s/gn/gnu/
> +(define-public arrayfire
> +(package
> + (name "arrayfire")
Please try to indent as in the other files.
> + ("cmake" ,cmake)))
> + (build-system cmake-build-system)
CMake is not needed in ‘inputs’ when using ‘cmake-build-system’.
> + (arguments
> + `(#:configure-flags '("-DBUILD_OPENCL=ON" "-DBUILD_CUDA=OFF" "-DBUILD_GRAPHICS=OFF" "-DUSE_SYSTEM_BOOST_COMPUTE=ON" "-DUSE_SYSTEM_CLBLAS=ON" "-DUSE_SYSTEM_CLFFT=ON")
> + #:tests? #f))
Please add a comment above #:tests? #f to justify why tests are skipped.
> + (synopsis "ArrayFire: a general purpose GPU library. https://arrayfire.com")
> + (description "ArrayFire is a high performance software library for parallel computing with an easy-to-use API. Its array based function set makes parallel programming simple.Now on Guix")
‘guix lint’ will suggest some changes here. :-)
> + (home-page "http://arrayfire.com/")
> + (license (list license:gpl2
> + license:gpl2+
> + license:gpl3
> + license:gpl3+))))
What does it mean? Please add a comment above explaining what the
license list is about.
> + (synopsis "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
> + (description "glfw is an Open Source, multi-platform library for creating windows with OpenGL contexts and receiving input and events.")
s/Open Source//g
The GNU project focuses on free software, not “open source” (see
<https://www.gnu.org/philosophy/open-source-misses-the-point.html>), and
since every package in Guix is free, we don’t mention it in synopses.
Also, please see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>
on the kind of synopses/descriptions we try to provide to our users.
> +(define-public clBLAS
> + (package
> + (name "clBLAS")
Variable and package names should be lower-case.
> + (version "v2.10")
No “v”.
> + (native-inputs `(("autoconf" ,autoconf)
> + ("automake" ,automake)
Indentation.
> +(define-public opencl-headers
> +(let ((commit "c1770dc"))
> + (package
Indentation.
Could you send updated patches, preferably using ‘git send-email’?
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-04 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 2:28 [PATCH] Port Arrayfire to GNU Guix Dennis Mungai
2016-04-04 21:18 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).