From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] gnu: Add giac-xcas Date: Tue, 12 Apr 2016 00:23:26 +0200 Message-ID: <87a8kzbx9d.fsf@nicolasgoaziou.fr> References: <87inzt7cc3.fsf@nicolasgoaziou.fr> <87h9f9mvfg.fsf@nicolasgoaziou.fr> <878u0kp805.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apkCv-0004sX-6N for guix-devel@gnu.org; Mon, 11 Apr 2016 18:21:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apkCq-0001UC-71 for guix-devel@gnu.org; Mon, 11 Apr 2016 18:21:21 -0400 In-Reply-To: <878u0kp805.fsf@gnu.org> (Mathieu Lirzin's message of "Mon, 11 Apr 2016 15:52:58 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Lirzin Cc: Guix-devel Hello, Mathieu Lirzin writes: > In fact it is public. It is just that the module (gnu packages xiph) > use a different convention which is to define "public" variable with > =E2=80=98define=E2=80=99 and to add them to the #:export list of the modu= le, instead of > directly using =E2=80=98define-public=E2=80=99. Either way is equivalent= in Guile. OK. Understood. > It depends if this feature is essential for using xcas? If yes then > adding it as a propagated-input is still not required unless "latex, > makeindex, ..." are used using the PATH which could not be the case > since those programs are checked at configure time. > > WDYT? I removed perl, tcsh, texlive-minimal as inputs, and tried guix environment --ad-hoc texlive giac-xcas --fallback -- xcas I could preview the sheet using LaTeX. However, I sometimes got sh: pstopnm: command not found sh: pnmtopng: command not found Not sure it is related. Also, texlive-minimal is still in the closure, probably due to some other input, so it doesn't reduce the size of the package. > Looks good to me. guix lint is happy and the build is reproducible. I > have modified the indentation to follow our =E2=80=9Ccustom=E2=80=9D Emac= s rules. Here > is the updated patch. Funnily, I broke Emacs indentation on purpose because other package definitions in the file were disagreeing with it. I should have trusted good ole Emacs. > Is there a particular reason for not patching this within the > =E2=80=98arguments=E2=80=99 field? This is because the test issue is related to a given release, i.e., a given `source' field. OTOH, `arguments' are for control over the build process, which is not going to change anytime soon. To put it differently, I put the temporary fix in `snippet' and the persistent one in `arguments'. Moreover, you suggest to merge the two fixes into a single phase named `fix-makefiles', which, albeit correct, is less accurate than `patch-bin-cp'. Anyway, this is just nitpicking; I'm fine with all the changes you made. > Thanks and welcome! Thank you for the review. Regards, --=20 Nicolas Goaziou 0x80A93738