From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] gnu: Add gparted. Date: Sat, 28 May 2016 21:41:25 +0200 Message-ID: <87a8javul6.fsf@gnu.org> References: <87shx2xjrj.fsf@gnu.org> <20160528161855.GC16585@jasmine> <87r3cmxc9g.fsf@gnu.org> <20160528192829.GA29207@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6k72-0005dA-5l for guix-devel@gnu.org; Sat, 28 May 2016 15:41:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6k6y-0000wB-W8 for guix-devel@gnu.org; Sat, 28 May 2016 15:41:32 -0400 In-reply-to: <20160528192829.GA29207@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel Leo Famulari writes: > On Sat, May 28, 2016 at 08:34:19PM +0200, Roel Janssen wrote: >> Leo Famulari writes: >> > On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote: >> I tested with a USB drive. I could create a new partition table and a >> new partition. > > Great! > >> It seems all tests need to download DTDs from various places on the >> internet. The tests are related to the use of Scrollkeeper (which I >> disabled). >> >> As far as I can see there are no unit tests for the actual code. > > Ah, too bad. I guess it relies on the tests for parted / libparted. Yes, GParted is only a graphical user interface on top of libparted and optionally external partitioning command-line tools. >> >> + #:configure-flags '("--disable-scrollkeeper"))) >> > >> > I'm not sure what this means. Can you leave a comment explaining it? >> >> Of course! I'm not completely familiar with Scrollkeeper (although I >> also wrote a package recipe for it), but what I understand is that it is >> a program to manage various formats of documentation, and keep a central >> database that links to various forms of documentation. >> >> I added the following comment, but I think explaining the ins and outs of >> Scrollkeeper goes too far. Is the comment good enough? >> >> + ;; We don't use scrollkeeper elsewhere, so disable updating the >> + ;; scrollkeeper database with documentation from GParted. >> + #:configure-flags '("--disable-scrollkeeper"))) > > I think the comment is fine. > > On a related topic, trying to open the help from the "Help" menu gives > me a dialog box this text: > > "Unable to open GParted Manual help file > > Failed to execute child process "yelp" (No such file or directory)" > > I get the same result from the Debian package. I wonder if I would have > more success if I was running GNOME? > > Since the man page doesn't include any information about using the > program, it would be good to make sure the help application at least > works on GNOME. I am going to look further into this. Thanks for exposing this limitation (I hadn't tested this myself). Kind regards, Roel Janssen