From: Alex Kost <alezost@gmail.com>
To: Jelle Licht <jlicht@fsfe.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/4] gnu: node: Do not use bundled dependencies.
Date: Sat, 27 Aug 2016 23:38:13 +0300 [thread overview]
Message-ID: <87a8fydk22.fsf@gmail.com> (raw)
In-Reply-To: <20160827112333.1759-4-jlicht@fsfe.org> (Jelle Licht's message of "Sat, 27 Aug 2016 13:23:32 +0200")
Jelle Licht (2016-08-27 14:23 +0300) wrote:
> The Node build system was previously building its own copies of
> C-ares and http-parser.
>
> * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser.
> [arguments]: Add configure flags for using system libraries.
> ---
> gnu/packages/node.scm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index d1c5e1b..7c020e6 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -25,6 +25,7 @@
> #:use-module (guix derivations)
> #:use-module (guix download)
> #:use-module (guix build-system gnu)
> + #:use-module (gnu packages adns)
> #:use-module (gnu packages base)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages gcc)
> @@ -86,6 +87,8 @@ it does not buffer data, it can be interrupted at anytime.")
> '(#:configure-flags '("--shared-openssl"
> "--shared-zlib"
> "--shared-libuv"
> + "--shared-cares"
> + "--shared-http-parser"
> "--without-snapshot")
> #:phases
> (modify-phases %standard-phases
> @@ -158,7 +161,9 @@ it does not buffer data, it can be interrupted at anytime.")
> (inputs
> `(("libuv" ,libuv)
> ("openssl" ,tls:openssl)
> - ("zlib" ,zlib)))
> + ("zlib" ,compression:zlib)
This change shouldn't belong this patch: here you use 'compression'
prefix which is introduced by the next patch. This would leave the git
repo in a broken state on this commit.
> + ("http-parser" ,http-parser)
> + ("c-ares" ,c-ares)))
> (synopsis "Evented I/O for V8 JavaScript")
> (description "Node.js is a platform built on Chrome's JavaScript runtime
> for easily building fast, scalable network applications. Node.js uses an
--
Alex
next prev parent reply other threads:[~2016-08-27 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 11:23 [PATCH 0/4] Unbundle node dependencies patch series Jelle Licht
2016-08-27 11:23 ` [PATCH 1/4] gnu: node: Add http-parser Jelle Licht
2016-08-27 20:33 ` Alex Kost
2016-08-27 11:23 ` [PATCH 2/4] gnu: node: Add search path specification for 'NODE_PATH' Jelle Licht
2016-08-27 11:23 ` [PATCH 3/4] gnu: node: Do not use bundled dependencies Jelle Licht
2016-08-27 20:38 ` Alex Kost [this message]
2016-08-28 19:38 ` Jelle Licht
2016-08-29 8:30 ` Alex Kost
2016-08-27 11:23 ` [PATCH 4/4] gnu: node: Use compression: prefix Jelle Licht
2016-08-27 20:42 ` Alex Kost
2016-09-01 12:43 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8fydk22.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).