From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add libicns Date: Sat, 03 Sep 2016 11:27:30 +0100 Message-ID: <87a8fpqnvx.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <3b92e609-3e2f-9f3e-3294-0e8f7a3ae558@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg8B9-0007Mu-SL for guix-devel@gnu.org; Sat, 03 Sep 2016 06:28:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bg8B2-00014r-Rc for guix-devel@gnu.org; Sat, 03 Sep 2016 06:28:02 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bg8Ay-00012w-Lh for guix-devel@gnu.org; Sat, 03 Sep 2016 06:27:56 -0400 In-Reply-To: <3b92e609-3e2f-9f3e-3294-0e8f7a3ae558@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Brendan Tildesley , guix-devel@gnu.org Brendan Tildesley writes: > From 64ca4155a754a93b26a1002185950f49469197f3 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Sat, 3 Sep 2016 05:53:56 +1000 > Subject: [PATCH] gnu: Add libicns > > * gnu/packages/image.scm (libicns): New variable Thanks! Nit-pick: we end commit messages and descriptions with a ".", but this can be fixed by the committer. > +(define-public libicns > + (package > + (name "libicns") > + (version "0.8.1") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://sourceforge.net/projects/icns/files/libicns-" Could you change this to the mirror://sourceforge system? > + version ".tar.gz/download")) > + (file-name (string-append "libicns-" version ".tar.gz")) Changing file-name is only necessary if it doesn't already use a "package-version.ext" style name, which this appears to do. `guix lint` will tell whether this is needed. > + (sha256 (base32 > + "1hjm8lwap7bjyyxsyi94fh5817xzqhk4kb5y0b7mb6675xw10prk")))) > + (build-system gnu-build-system) > + (arguments > + ;; no tests > + '(#:tests? #f)) > + (inputs `(("libpng" ,libpng) > + ("jasper" ,jasper))) We typically add the inputs on a new line, but I have no strong opinions on this. > + (home-page "http://icns.sourceforge.net/") > + (synopsis "Library for handling Mac OS icns resource files") > + (description > + "libicns is a library for the manipulation of Mac OS IconFamily resource > +type files (ICNS). icns2png and png2icns are provided to convert between PNG When describing command-line tools, it looks prettier in generated documentation by using `@command(icns2png)`, but this is not always the case or necessary. > +and ICNS. icns2png will extract image files from ICNS files under names like > +\"Foo_48x48x32.png\" useful for installing for use with .desktop files.") > + (license (list license:lgpl2.1+ ; libicns > + license:gpl2+)))) ; icns2png, png2icns, icontainer2png A couple of files are "lgpl2+" as well. Additionally this package bundles "m4" even if it doesn't use it. Can you remove it with a "origin" snippet? See e.g. "xcb-util-xrm" for how that's done. The rest looks fine to me. Can you send an updated patch? Thanks! Marius