From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add libjxr. Date: Sat, 22 Oct 2016 04:33:18 -0400 Message-ID: <87a8dwrdf5.fsf@openmailbox.org> References: <87eg39qvjh.fsf@openmailbox.org> <20161021235859.GA9570@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxrkP-0008Nn-T2 for guix-devel@gnu.org; Sat, 22 Oct 2016 04:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxrkM-0008V7-NY for guix-devel@gnu.org; Sat, 22 Oct 2016 04:33:45 -0400 Received: from smtp26.openmailbox.org ([62.4.1.60]:54717 helo=smtp11.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bxrkM-0008Uo-BA for guix-devel@gnu.org; Sat, 22 Oct 2016 04:33:42 -0400 In-Reply-To: <20161021235859.GA9570@jasmine> (Leo Famulari's message of "Fri, 21 Oct 2016 19:58:59 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Fri, Oct 21, 2016 at 04:47:14PM -0400, Kei Kebreau wrote: >> This is a patch I think we need before fixing up freeimage. Thoughts? > > Thanks for working on this! > >> + (uri (string-append "mirror://debian/pool/main/j/jxrlib/jxrlib_" >> + version ".orig.tar.gz")) > > Why not download it from the upstream site? We prefer to do that when > possible. > > https://jxrlib.codeplex.com/releases/view/107208 > The URL for the upstream site's tarball is http://download-codeplex.sec.s-msft.com/Download/Release?ProjectName=jxrlib&DownloadId=685250&FileTime=130142428056630000&Build=21031. Is something like that acceptable in Guix code? I know it works with wget, but I was hesitant to use it as the source URL. >> + (license >> + (license:non-copyleft >> + "file://Makefile" >> + "See the header of the Makefile in the distribution.")) > > That looks like a 2 clause BSD license: > https://opensource.org/licenses/BSD-2-Clause > Indeed it does. I'll have it changed in the next patch I submit. >> diff --git a/gnu/packages/patches/libjxr-fix-typos.patch >> b/gnu/packages/patches/libjxr-fix-typos.patch >> new file mode 100644 >> index 0000000..3c051dd >> --- /dev/null >> +++ b/gnu/packages/patches/libjxr-fix-typos.patch >> @@ -0,0 +1,60 @@ >> +Description: Fix typos and remove some warnings >> +Author: Mathieu Malaterre > > Can you include a link to the source of this patch? > This patch comes from Debian's set of patches for the sources. Could I leave "This patch comes from Debian" with the link to it on the top, or is more detail necessary? >> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch >> b/gnu/packages/patches/libjxr-use-cmake.patch >> new file mode 100644 >> index 0000000..cb5919e >> --- /dev/null >> +++ b/gnu/packages/patches/libjxr-use-cmake.patch >> @@ -0,0 +1,143 @@ >> +Description: Prefer a cmake based build system >> +Author: Mathieu Malaterre >> +Forwarded: https://jxrlib.codeplex.com/discussions/440294 > > Why doesn't upstream's build system work? Upstream's build system simply doesn't have configuration or installation targets in the provided Makefile. Using the cmake patch makes the definition cleaner at the cost of relying on outside work [1]. If this is not acceptable, I can see about writing manual replacement phases to the best of my ability. [1]: https://jxrlib.codeplex.com/discussions/440294 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCyROAAoJEOal7jwZRnoNNNkP/1iEzumYc2Smgc87A990msLB 82uCJJG8Q7usv/7Jk8OK7EiGESIuRGOTDrKWYSk0+9f3d0e1gMZVien71i7C806v 9uAniGDakXcKWTmFKrgMHqY1k4F27hSqHb4nz8+xXvchdnmQmBJxnq84llt4boMN aavmQjW0NTaTxKCsnzBNTovQf1c2hH0hN+F8defYn+q9xThY3JJXsGkyaT0SR+SD KamuJpL4TTNb4+avWBNL1uKNs2YxzAjllvXqlEmG7qMHttKYNCDVl5Q0m3DdLc4E 2h7rSlt5Ofu4IjwaVX0ywobNsX8TGAOp9iFmdckJIUSBhHo+ekZmgypM3buLPsE8 LTJe3KJ5/1ocN7qAZTtdOTNR8K1nARqtvJK3g9QT3ecPv8kvqs7H5gs18ogO/A4C mizG6HcoXhFcXV7tNnaDEUXUr3LQc4O0b5gSYRYVmp+MFCmu9A/AEeCwYR3ZZDfA QdcUp1TeWxXuiZuaVz/w3vNG/y9EYbp/fUwsl64qaTiGWlzGo75ngU+324P3cBtw ON0HekH/dioXDY49sXikEyV/LWC2Y1EbtlyoO8R/1VFdfei5qi4fvTth1yHAyWPq lKB+nI4EImzZF8ZwI2siEXRNax2/dPPftP8KS+f8mpcWW7QY31J5OBuhKrF47k4m YWOP140/jhCnBOOOBH87 =yp0N -----END PGP SIGNATURE----- --=-=-=--