From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] mps-youtube, revision 3 Date: Sat, 05 Nov 2016 12:33:13 +0000 Message-ID: <87a8de6r92.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <8760o3nkl9.fsf@we.make.ritual.n0.is> <20161104192302.19335-1-ng0@we.make.ritual.n0.is> <081db68d-fd77-b857-ba1a-70600469ffd1@crazy-compilers.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c309x-0005NL-Rg for guix-devel@gnu.org; Sat, 05 Nov 2016 08:33:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c309s-0007RY-QL for guix-devel@gnu.org; Sat, 05 Nov 2016 08:33:21 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53561) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c309s-0007Qr-MI for guix-devel@gnu.org; Sat, 05 Nov 2016 08:33:16 -0400 In-Reply-To: <081db68d-fd77-b857-ba1a-70600469ffd1@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel , guix-devel@gnu.org --=-=-= Content-Type: text/plain Hartmut Goebel writes: > Am 04.11.2016 um 20:23 schrieb ng0: >> [PATCH 1/2] gnu: Add python-pafy. >> >> - made youtube-dl propagated-input as suggested by harmut >> >> [PATCH 2/2] gnu: Add mps-youtube. >> >> - no changes >> > > Both LGTM. > > Adding the comment about youtube_dl was a good idea :-) Both of these packages have 'or later' in the source license header. Also mps-youtube does not need mpv or ffmpeg in inputs, since they are optional runtime dependencies. Additionally home-page should be https. Other than that this works great, neat program! I pushed the patches with these changes, and a minor edit to the mps-youtube description to make it clear that mplayer or mpv is required. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYHdGJAAoJEKKgbfKjOlT62XsH/0nsWkS1UOwFDw5J4fcvfwNP 7V46Ko81pUFNOch6pzYv/fPGbRO04MucQmtl1U6oyNO1myeG5G3kz8FAYn6pRnp/ Wflwwrrt0RifPLv1JtN8a8R0HfN53OX+HjPx80k0E7FpGoDcoN7853tM84ItlieU 1c3Pqvr4Em1RxoZ6AQxACUw0TN57uBmIvHyO8KOj1HvcgFHqKDm+ociztKVO/JEf qJ0UcRhm4tY7QiWdl3Oy6HM/wEbHtvK6Xtt+cOujtExk7v3AhokyQd5e+p1VV0ru EYhpBAYZSbaSAZf+w/Cz4hXg5AwSwftqXMBPA6z4GCFUSab9kAPNNg0a1U6QrmI= =NFAf -----END PGP SIGNATURE----- --=-=-=--