From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 1/2] gnu: Add LLVM variant with RTTI support. Date: Tue, 08 Nov 2016 21:02:00 +0100 Message-ID: <87a8d991vr.fsf@elephly.net> References: <20161106193424.11435-1-rekado@elephly.net> <20161107231017.GA26573@jasmine> <87fun28k8p.fsf@elephly.net> <20161108160449.GB19400@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Cay-0003Ld-Jg for guix-devel@gnu.org; Tue, 08 Nov 2016 15:02:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Cau-000608-Hq for guix-devel@gnu.org; Tue, 08 Nov 2016 15:02:12 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21410) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Cau-0005zj-9g for guix-devel@gnu.org; Tue, 08 Nov 2016 15:02:08 -0500 In-reply-to: <20161108160449.GB19400@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Tue, Nov 08, 2016 at 09:10:46AM +0100, Ricardo Wurmus wrote: >> >> Leo Famulari writes: >> >> > On Sun, Nov 06, 2016 at 08:34:23PM +0100, Ricardo Wurmus wrote: >> >> * gnu/packages/llvm.scm (llvm-with-rtti): New variable. >> > >> > Seems okay, although would it make sense to enable this in the main LLVM >> > package? >> >> I’m not sure, because it seems to require dependent packages to also >> support this or else be built with “-fno-rtti”. We should build this >> out in a separate branch and see how much damage this causes and how >> many changes to existing packages this requires. > > Perhaps, but let's not let it delay this patch :) Okay :) Pushed as 8ae60404510fedb89502e27c0e73f830ab429641. Thanks for the review! ~~ Ricardo