unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2.
Date: Thu, 10 Nov 2016 13:35:18 +0100	[thread overview]
Message-ID: <87a8d7tsvt.fsf@gnu.org> (raw)
In-Reply-To: <582452C4.9000700@crazy-compilers.com> (Hartmut Goebel's message of "Thu, 10 Nov 2016 11:58:12 +0100")

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 10.11.2016 um 11:46 schrieb Ludovic Courtès:
>>> > +    (arguments
>>> > +     `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes)
>> So probably we should only build the Python 2 variant?  WDYT?
>>
>
> The main feature of PyPDF2 is that is supports Python 3, what the old
> pyPdf does not. So we need Python 3.
>
> The test suite does not fail in the sense that it shows bugs, but in a
> way that shows the test suite was not adopted to work with Python 3. The
> test-suite is negligible anyway.  I'll update the comment.

Hmm, OK.  That doesn’t make it sounds like it’s really safe to use with
Python 3.

At the very least, the test suite should be disabled only for the
Python 3 variant IMO, and with a slightly more detailed explanation in
the comment.

Thanks!

Ludo’.

  reply	other threads:[~2016-11-10 12:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 21:37 [PATCH 1/3] gnu: Add python-pypdf2 Hartmut Goebel
2016-11-08 21:37 ` [PATCH 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-08 23:57   ` Leo Famulari
2016-11-09 22:04     ` Hartmut Goebel
2016-11-09  7:19   ` Efraim Flashner
2016-11-09 22:10     ` Hartmut Goebel
2016-11-08 21:37 ` [PATCH 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-09  0:02   ` Leo Famulari
2016-11-09 22:19     ` Hartmut Goebel
2016-11-08 23:55 ` [PATCH 1/3] gnu: Add python-pypdf2 Leo Famulari
2016-11-09 21:59   ` Hartmut Goebel
2016-11-09 22:39 ` [Patch v2 " Hartmut Goebel
2016-11-09 22:39   ` [Patch v2 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-10 10:47     ` Ludovic Courtès
2016-11-09 22:39   ` [Patch v2 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-10  7:51     ` Efraim Flashner
2016-11-10 10:48       ` Ludovic Courtès
2016-11-10 13:28         ` Hartmut Goebel
2016-11-10 10:46   ` [Patch v2 1/3] gnu: Add python-pypdf2 Ludovic Courtès
2016-11-10 10:58     ` Hartmut Goebel
2016-11-10 12:35       ` Ludovic Courtès [this message]
2016-11-10 13:10         ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8d7tsvt.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).