From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: curl: Add ca-bundle to config. Date: Wed, 04 Jan 2017 17:07:07 +0000 Message-ID: <87a8b6oitg.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <20170104144655.12321-1-ng0@libertad.pw> <20170104144655.12321-2-ng0@libertad.pw> <874m1ezugu.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <871swizsqv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOp1j-0005AS-Ju for guix-devel@gnu.org; Wed, 04 Jan 2017 12:07:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOp1f-0003W3-Hb for guix-devel@gnu.org; Wed, 04 Jan 2017 12:07:03 -0500 Received: from aibo.runbox.com ([91.220.196.211]:57794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOp1f-0003UC-AF for guix-devel@gnu.org; Wed, 04 Jan 2017 12:06:59 -0500 In-Reply-To: <871swizsqv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke writes: > Marius Bakke writes: > >> ng0 writes: >> >>> * gnu/packages/curl.scm (curl)[arguments]: Add "--with-ca-bundle" configure flag. >>> [arguments]: Disable failing test number 324. >>> --- >>> gnu/packages/curl.scm | 13 ++++++++++++- >>> 1 file changed, 12 insertions(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm >>> index 7329d870d..3473055b8 100644 >>> --- a/gnu/packages/curl.scm >>> +++ b/gnu/packages/curl.scm >>> @@ -4,6 +4,7 @@ >>> ;;; Copyright © 2015 Tomáš Čech >>> ;;; Copyright © 2015 Ludovic Courtès >>> ;;; Copyright © 2016 Leo Famulari >>> +;;; Copyright © 2017 ng0 >>> ;;; >>> ;;; This file is part of GNU Guix. >>> ;;; >>> @@ -65,7 +66,8 @@ >>> ("pkg-config" ,pkg-config) >>> ("python" ,python-2))) >>> (arguments >>> - `(#:configure-flags '("--with-gnutls" "--with-gssapi") >>> + `(#:configure-flags '("--with-gnutls" "--with-gssapi" >>> + "--with-ca-bundle=/etc/ssl/certs/ca-certificates.crt") >> >> This may not work on all distros, and is "impure" since this path is not >> managed by Guix. If we are doing this, it should be referring to >> (string-append (assoc-ref %build-inputs "nss-certs") "/etc/ssl/..."). >> That will likely fix the test as well. > > I realized shortly after posting why this wasn't done already. Curl has > 1403 dependent packages, which would apply for "nss-certs" as well if > that is added as input. Obviously we want to be able to update TLS > certificates quickly without rebuilding ~1/4 of the tree. > > Perhaps it could be added as a separate package, or by e.g. renaming the > current curl package to "curl-minimal". Okay, I will wait for more people to comment on the best route to follow here for curl. For gnurl: As right now gnurl is only required by gnunet and related packages, I will send in a patch for this in advance for gnurl. -- ♥Ⓐ ng0 PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org