From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 5/6] gnu: Add ceph.
Date: Tue, 17 Jan 2017 23:47:54 +0100
Message-ID: <87a8apb8x1.fsf@gnu.org>
References: <20170115203338.19769-1-mbakke@fastmail.com>
	<20170115203338.19769-6-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcXq-0002pk-3j
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:48:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cTcXl-0001lt-87
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:48:02 -0500
In-Reply-To: <20170115203338.19769-6-mbakke@fastmail.com> (Marius Bakke's
	message of "Sun, 15 Jan 2017 21:33:37 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/distributed-filesystems.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

[...]

> +             (substitute* "src/Makefile.in"
> +               ;; By default, the PYTHONPATH is set to "src/pybind".
> +               ;; Make sure our libraries are found too.
> +               (("export PYTHONPATH=3D") (string-append "export PYTHONPA=
TH=3D"
> +                                                      (getenv "PYTHONPAT=
H")
> +                                                      ":"))

I=E2=80=99d move (string-append =E2=80=A6) on the next line (for the follow=
ing
substitutions as well.)

> +    ;; Ceph is licensed under LGPL2.1, but includes a number of componen=
ts
> +    ;; covered by other licenses. Consult COPYING for full information.
> +    (license (list license:lgpl2.1
> +                   license:cc-by-sa3.0    ; documentation
> +                   license:bsd-2          ; xxHash
> +                   license:bsd-3
> +                   license:gpl3
> +                   license:gpl2
> +                   license:public-domain
> +                   license:boost1.0
> +                   license:expat))))

No =E2=80=9Cor any later version=E2=80=9D clause for the GNU licenses here?

Then apart from the wrapping that you mentioned in the cover letter and
other issues, that looks good.  Great work!

Ludo=E2=80=99.