unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/6] gnu: Add rocksdb.
Date: Wed, 18 Jan 2017 01:10:58 +0100	[thread overview]
Message-ID: <87a8ap9qi5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87fukhb95t.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * gnu/packages/databases.scm (rocksdb): New variable.
>
> [...]
>
>> +           (lambda* (#:key (make-flags '()) #:allow-other-keys)
>> +             ;; Prevent the build from adding machine-specific optimizations.
>> +             ;; This does not work if passed as a make flag...
>> +             (setenv "PORTABLE" "1")
>> +             (and (zero? (apply system* "make" "static_lib" make-flags))
>> +                  (zero? (apply system* "make" "shared_lib" make-flags)))))
>
> We could avoid building the static libs if nothing requires it; no
> strong opinion though.

I do tend to simply drop the static libs (see e.g. "dlib" or
"capnproto"), but in this case Ceph requires the static library. I will
make another attempt at making it use "-lrocksdb" instead of the ".a"
before pushing this package however, now that I know the build better.

In the crypto++ case, static is the default make target, so I suspect
it's "normal" to use. But as I recently realized, grafting most likely
won't work with static libraries, so I will remove it. Being a crypto
library and all. We should discourage it indeed.

>> +    (home-page "http://rocksdb.org/")
>> +    (synopsis "Persistent key-value store for fast storage")
>> +    (description
>> +     "RocksDB is an embeddable, persistent key-value storage library that is
>> +designed for flash and RAM storage.")
>
> Could you expound a little bit?

How about:

(synopsis "Persistent key-value store for flash and RAM storage")
(description
  "RocksDB is a library that forms the core building block for a fast
  key-value server, especially suited for storing data on flash drives.
  It has a Log-Structured-Merge-Database (LSM) design with flexible
  tradeoffs between Write-Amplification-Factor (WAF),
  Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF).
  It has multi-threaded compactions, making it specially suitable for
  storing multiple terabytes of data in a single database.
  It is based on @code{LevelDB}.")

(taken from the README)

Thanks a lot for the reviews!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-01-18  0:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-15 20:33 [PATCH 0/6] gnu: Add ceph Marius Bakke
2017-01-15 20:33 ` [PATCH 1/6] gnu: Add leveldb Marius Bakke
2017-01-17 22:34   ` Ludovic Courtès
2017-01-15 20:33 ` [PATCH 2/6] gnu: Add crypto++ Marius Bakke
2017-01-17 22:38   ` Ludovic Courtès
2017-01-17 22:46   ` Leo Famulari
2017-01-17 22:57     ` Marius Bakke
2017-01-15 20:33 ` [PATCH 3/6] gnu: Add python-cram Marius Bakke
2017-01-17 22:36   ` Ludovic Courtès
2017-01-15 20:33 ` [PATCH 4/6] gnu: Add rocksdb Marius Bakke
2017-01-17 22:42   ` Ludovic Courtès
2017-01-18  0:10     ` Marius Bakke [this message]
2017-01-18 21:29       ` Ludovic Courtès
2017-01-15 20:33 ` [PATCH 5/6] gnu: Add ceph Marius Bakke
2017-01-17 22:47   ` Ludovic Courtès
2017-01-17 23:11     ` Marius Bakke
2017-01-18 21:27       ` Ludovic Courtès
2017-01-15 20:33 ` [PATCH 6/6] gnu: fio: Enable rbd support Marius Bakke
2017-01-17 22:48   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8ap9qi5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).