From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 6/6] gnu: Add neovim.
Date: Tue, 24 Jan 2017 22:31:13 +0100
Message-ID: <87a8ag5en2.fsf@gnu.org>
References: <20170124144015.24473-1-ricardo.wurmus@mdc-berlin.de>
	<20170124144015.24473-6-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cW8gT-000732-9K
	for guix-devel@gnu.org; Tue, 24 Jan 2017 16:31:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cW8gO-0004gq-DB
	for guix-devel@gnu.org; Tue, 24 Jan 2017 16:31:21 -0500
In-Reply-To: <20170124144015.24473-6-ricardo.wurmus@mdc-berlin.de> (Ricardo
	Wurmus's message of "Tue, 24 Jan 2017 15:40:15 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> * gnu/packages/vim.scm (neovim): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'set-lua-paths
> +           (lambda* (#:key inputs #:allow-other-keys)

Maybe add a comment/link about the placeholder thing.

> +    (inputs
> +     `(("libuv" ,libuv)
> +       ("gettext" ,gettext-minimal)
> +       ("gperf" ,gperf)

I=E2=80=99d expect gettext and gperf to be native inputs instead?

Otherwise LGTM, thanks!

Ludo=E2=80=99.