From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] gnu: Add zpaq.
Date: Mon, 30 Jan 2017 23:54:46 +0100
Message-ID: <87a8a8jgzt.fsf@gnu.org>
References: <20170127195924.22959-1-me@tobias.gr>
	<20170127195924.22959-3-me@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cYKqb-0000qT-5E
	for guix-devel@gnu.org; Mon, 30 Jan 2017 17:54:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cYKqX-0008Si-8D
	for guix-devel@gnu.org; Mon, 30 Jan 2017 17:54:53 -0500
In-Reply-To: <20170127195924.22959-3-me@tobias.gr> (Tobias Geerinckx-Rice's
	message of "Fri, 27 Jan 2017 20:59:24 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/compression.scm (zpaq): New variable.

[...]

> +        (string-append "CXXFLAGS=3D-O3 -mtune=3Dgeneric -DNDEBUG"
> +                       ,(match (or (%current-target-system)
> +                                   (%current-system))
> +                               ("x86_64-linux"  " -march=3Dnocona")
> +                               ("i686-linux"    " -march=3Di686")
> +                               (_               "")))

Maybe add a note as to why these are needed.

> +    (home-page "http://mattmahoney.net/dc/zpaq.html")
> +    (synopsis "Incremental journaling archiver")
> +    (description "ZPAQ is a command-line archiver that backs up faster a=
nd
> +compresses better than most other popular archivers in realistic situati=
ons
> +with many duplicate and already compressed files.  It backs up only thos=
e files

I=E2=80=99d tone down the first sentence.  :-)

Otherwise LGTM, thank you!

Ludo=E2=80=99.