From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Huang\, Ying" <huang_ying_caritas@163.com>
Subject: Re: [PATCH -v2 1/2] build: union: Add create-all-directories?
	parameter to union-build
Date: Thu, 09 Mar 2017 19:43:03 +0800
Message-ID: <87a88un0ag.fsf@163.com>
References: <20170307110749.31614-1-huang.ying.caritas@gmail.com>
	<87k27zlmdn.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36195)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <huang_ying_caritas@163.com>) id 1clwTN-0003e7-Fg
	for guix-devel@gnu.org; Thu, 09 Mar 2017 06:43:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <huang_ying_caritas@163.com>) id 1clwTK-00086z-Aw
	for guix-devel@gnu.org; Thu, 09 Mar 2017 06:43:09 -0500
In-Reply-To: <87k27zlmdn.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Wed, 08 Mar 2017 18:16:36 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Courtès) writes:

> Huang Ying <huang.ying.caritas@gmail.com> skribis:
>
>> * guix/build/union.scm (union-build): Add create-all-directories? keyword
>>   parameter.  To add/remove some files from the directory.
>
> I guess this is needed for fonts.dir, but could you explain why it is?
> (The explanation could go as a comment above the ‘union-build’ call in
> the second patch.)

Sure.

Best Regards,
Huang, Ying

> Other than that LGTM.
>
> Thanks,
> Ludo’.