Add OggVorbis support to moc

Add OggVorbis support to moc

[Mark Meyer]

[-- Attachment #1: Type: text/plain, Size: 94 bytes --]

Hi list,
please consider the attached patch, it adds OggVorbis support to moc.

Cheers, Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: moc-ogg --]
[-- Type: text/x-patch, Size: 818 bytes --]

From 9517f2beea0ab4199ad5d558bfcab82a5df713bd Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Mon, 3 Apr 2017 21:29:25 +0200
Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>

* gnu/packages/music.scm (moc): Add OggVorbis support.
---
 gnu/packages/music.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f70945c6..8f3c96865 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2236,6 +2236,8 @@ with a number of bugfixes and changes to improve IT playback.")
        ("libmodplug" ,libmodplug)
        ("libmpcdec" ,libmpcdec)
        ("libmad" ,libmad)
+       ("libogg" ,libogg)
+       ("libvorbis" ,libvorbis)
        ("ncurses" ,ncurses)
        ("openssl" ,openssl)
        ("sasl" ,cyrus-sasl)
-- 
2.12.1

Re: Add OggVorbis support to moc

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

Mark,

On 03/04/17 21:33, Mark Meyer wrote:
> Hi list,

Hi!

Patches like this will (or should) get more attention on
guix-patches@gnu.org. guix-devel is for more general discussion.

> please consider the attached patch, it adds OggVorbis support to moc.

Applied as 6beaa5a02a516c061c2ff86ce4beb43374015194, with some changes
to the commit message. Please take a look.

Also: your patch had ‘2017-04-03 Mark Meyer <mark@ofosos.org>’ as the
commit title. Was this intended?

Thanks!

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

Re: Add OggVorbis support to moc

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Mark Meyer <mark@ofosos.org> writes:

> Hi list,
> please consider the attached patch, it adds OggVorbis support to moc.
>
> Cheers, Mark
>
> From 9517f2beea0ab4199ad5d558bfcab82a5df713bd Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Mon, 3 Apr 2017 21:29:25 +0200
> Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>
>
> * gnu/packages/music.scm (moc): Add OggVorbis support.
> ---
>  gnu/packages/music.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2f70945c6..8f3c96865 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2236,6 +2236,8 @@ with a number of bugfixes and changes to improve IT playback.")
>         ("libmodplug" ,libmodplug)
>         ("libmpcdec" ,libmpcdec)
>         ("libmad" ,libmad)
> +       ("libogg" ,libogg)
> +       ("libvorbis" ,libvorbis)
>         ("ncurses" ,ncurses)
>         ("openssl" ,openssl)
>         ("sasl" ,cyrus-sasl)

It seems that Ogg Vorbis support already works in this package, probably
because of ffmpeg support. Do Ogg Vorbis files not work for you without
this patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Add OggVorbis support to moc

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Kei Kebreau <kei@openmailbox.org> writes:

> Mark Meyer <mark@ofosos.org> writes:
>
>> Hi list,
>> please consider the attached patch, it adds OggVorbis support to moc.
>>
>> Cheers, Mark
>>
>> From 9517f2beea0ab4199ad5d558bfcab82a5df713bd Mon Sep 17 00:00:00 2001
>> From: Mark Meyer <mark@ofosos.org>
>> Date: Mon, 3 Apr 2017 21:29:25 +0200
>> Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>
>>
>> * gnu/packages/music.scm (moc): Add OggVorbis support.
>> ---
>>  gnu/packages/music.scm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 2f70945c6..8f3c96865 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2236,6 +2236,8 @@ with a number of bugfixes and changes to improve IT playback.")
>>         ("libmodplug" ,libmodplug)
>>         ("libmpcdec" ,libmpcdec)
>>         ("libmad" ,libmad)
>> +       ("libogg" ,libogg)
>> +       ("libvorbis" ,libvorbis)
>>         ("ncurses" ,ncurses)
>>         ("openssl" ,openssl)
>>         ("sasl" ,cyrus-sasl)
>
> It seems that Ogg Vorbis support already works in this package, probably
> because of ffmpeg support. Do Ogg Vorbis files not work for you without
> this patch?

Oh, I see the patch has already been applied. I guess we'll see how this
affects things.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Add OggVorbis support to moc

[Mark Meyer]

They're not working for me. Specifically ogg Streaming.

Cheers, Mark

On Tue, Apr 4, 2017, at 16:08, Kei Kebreau wrote:
> Mark Meyer <mark@ofosos.org> writes:
> 
> > Hi list,
> > please consider the attached patch, it adds OggVorbis support to moc.
> >
> > Cheers, Mark
> >
> > From 9517f2beea0ab4199ad5d558bfcab82a5df713bd Mon Sep 17 00:00:00 2001
> > From: Mark Meyer <mark@ofosos.org>
> > Date: Mon, 3 Apr 2017 21:29:25 +0200
> > Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>
> >
> > * gnu/packages/music.scm (moc): Add OggVorbis support.
> > ---
> >  gnu/packages/music.scm | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> > index 2f70945c6..8f3c96865 100644
> > --- a/gnu/packages/music.scm
> > +++ b/gnu/packages/music.scm
> > @@ -2236,6 +2236,8 @@ with a number of bugfixes and changes to improve IT playback.")
> >         ("libmodplug" ,libmodplug)
> >         ("libmpcdec" ,libmpcdec)
> >         ("libmad" ,libmad)
> > +       ("libogg" ,libogg)
> > +       ("libvorbis" ,libvorbis)
> >         ("ncurses" ,ncurses)
> >         ("openssl" ,openssl)
> >         ("sasl" ,cyrus-sasl)
> 
> It seems that Ogg Vorbis support already works in this package, probably
> because of ffmpeg support. Do Ogg Vorbis files not work for you without
> this patch?
> Email had 1 attachment:
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark@ofosos.org