From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Treating tests as special case Date: Thu, 05 Apr 2018 17:17:09 +0200 Message-ID: <87a7uhk7ii.fsf@elephly.net> References: <20180405052439.GA30291@thebird.nl> <87efjuj6f2.fsf@elephly.net> <87efjtzqo4.fsf@gnu.org> <20180405145929.GA345@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f46dp-0000rb-Vd for guix-devel@gnu.org; Thu, 05 Apr 2018 11:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f46dn-0004Rs-9K for guix-devel@gnu.org; Thu, 05 Apr 2018 11:17:33 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f46dn-0004Rg-1r for guix-devel@gnu.org; Thu, 05 Apr 2018 11:17:31 -0400 In-reply-to: <20180405145929.GA345@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Pjotr Prins Cc: guix-devel@gnu.org Pjotr Prins writes: > If all the inputs are the same the test will *always* pass. There is > no point to it! The only way such a test won't pass it by divine > intervention or real hardware problems. Both we don't want to test > for. > > If tests are so important to rerun: tell me why we are not running > tests when substituting binaries? I don=E2=80=99t understand this. People only run tests when they haven=E2= =80=99t been run on the build farm, because that=E2=80=99s part of the build. So when t= he tests have passed (and the few short phases after that), then we have substitutes anyway, and so users won=E2=80=99t re-run tests. If you get substitutes you don=E2=80=99t need to run the tests. Any change here seems to only affect the case where you build locally even though there are substitutes. I=E2=80=99d say that this is a pretty r= are use case. Build farms do this, but they build binaries (and if they differ from binaries built elsewhere the tests may also behave differently). -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net