From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Status of Submitted Patches Date: Sun, 20 May 2018 11:40:52 +0200 Message-ID: <87a7suwtp7.fsf@elephly.net> References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net> <871sfxev9w.fsf@elephly.net> <7626275c-3eee-bb05-ab9d-4c88ec6f0329@swecha.net> <87r2nvjte6.fsf@elephly.net> <5ab51417-b635-9725-9f48-3bc3f9b61fdf@swecha.net> <87tvsko2wd.fsf@elephly.net> <7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net> <87zi28kt82.fsf@elephly.net> <8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net> <87k1takumm.fsf@elephly.net> <87o9hycwl6.fsf@elephly.net> <87r2mhdeap.fsf@elephly.net> <618c131c-6ba6-e525-aefc-72acca1c910f@swecha.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKKr0-0000In-TV for guix-devel@gnu.org; Sun, 20 May 2018 05:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKKqx-0001pE-19 for guix-devel@gnu.org; Sun, 20 May 2018 05:42:14 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fKKqw-0001ot-RH for guix-devel@gnu.org; Sun, 20 May 2018 05:42:10 -0400 In-reply-to: <618c131c-6ba6-e525-aefc-72acca1c910f@swecha.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sahitihi Cc: guix-devel@gnu.org Hi Sahithi, >> While this achieves the goal for a single character it does not >> constitute a custom port. Have you read the documentation for >> =E2=80=9Cmake-custom-port=E2=80=9D in the Guile manual? > > I have tried with the following code for, G=C3=A1bor helped me in process= [=E2=80=A6] Oh, I haven=E2=80=99t seen those emails on the mailing list. Please keep t= he discussion on the mailing list so that all mentors and the community can comment. > the description for that goes this way.... > > The input taken from input port is read and stored in variable "s". > This variable is passed to make-soft-port. The variable s is > capitalized by locale conversion then binded with color. the result is > displayed when called. Please try to be a little more precise with the descriptions. You defined a new port with =E2=80=9Cmake-soft-port=E2=80=9D. The new port has= two important procedures: one that takes a single character, and another that takes a string. In the case of a single character you just pass it through to the current output port. In the case of a string, you colorize it first and then write it to the output port. The result is a port that will print a coloured string whenever you pass it a string. How would you use this in =E2=80=9C(guix store)=E2=80=9D? Note that we don= =E2=80=99t want to apply colour to any and all strings there. We want only certain messages to be coloured. Can you please prepare a patch to =E2=80=9C(guix store)=E2=80=9D that shows us how you would use this new port? As a first change, could you please add the relevant parts of =E2=80=9C(ice= -9 colorized)=E2=80=9D to a module in Guix? We probably don=E2=80=99t want to= depend on having users install this module separately. We also don=E2=80=99t need al= l of it. Please prepare a patch that adds only the relevant parts to =E2=80=9C(= guix ui)=E2=80=9D and update the copyright headers. > I have tried the other process using escape codes however failed with > the result i will come with this implementation and procedure in my next > mail I have not received this email. Have you worked on this yet? When you have problems with code please always provide the relevant parts of your code with the error messages, so that we can help you. I think that we need to start moving forward at a slighter higher speed. Thanks! -- Ricardo