From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf. Date: Wed, 04 Jul 2018 09:27:47 +0200 Message-ID: <87a7r7e9zg.fsf@gnu.org> References: <20180702101757.22792.51026@vcs0.savannah.gnu.org> <20180702101758.97A6020543@vcs0.savannah.gnu.org> <8736x1r1g0.fsf@netris.org> <874lhhwkz7.fsf@fastmail.com> <87a7r8nmuy.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1facCd-0004NE-6G for guix-devel@gnu.org; Wed, 04 Jul 2018 03:27:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1facCc-0007rJ-6i for guix-devel@gnu.org; Wed, 04 Jul 2018 03:27:51 -0400 In-Reply-To: <87a7r8nmuy.fsf@netris.org> (Mark H. Weaver's message of "Tue, 03 Jul 2018 15:24:53 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org Hello, Mark H Weaver skribis: > Marius Bakke writes: [...] >> I'm sorry, I forgot to address your actual concerns. The (buggy) >> workaround was put in place and discussed in >> . The meat of it can be found in (guix >> build-system meson): >> >> ;; XXX PatchELF fails to build on armhf, so we skip >> ;; the 'fix-runpath' phase there for now. It is used >> ;; to avoid superfluous entries in RUNPATH as described >> ;; in , so armhf may now >> ;; have different runtime dependencies from other arches. > > Thanks for this, but I'd still like to know the answer to my questions: > "What does the [fix-runpath] phase accomplish, and how will armhf users > be disadvantaged by the removal of that phase?" As discussed in and , Meson does not (or did not) adjust RUNPATHs upon installation (contrary to what Libtool does, for instance.) Consequently, the RUNPATH is left with /tmp/guix-build-=E2=80=A6 entries, w= hich is not great but okay, but more importantly if usually lacks OUTPUT/lib as well. However, the commit Marius referred to=C2=B9 as well as what you reported f= or Epiphany in #31974 suggest that things are improving in Meson proper, and that we might be able to remove that =E2=80=98fix-runpath=E2=80=99 phas= e altogether soon. I think we should simply try building things without =E2=80=98fix-runpath= =E2=80=99 and see if =E2=80=98validate-runpath=E2=80=99 reports anything. Thoughts? Ludo=E2=80=99. =C2=B9 https://github.com/mesonbuild/meson/commit/e3757e3d3cf24327c89dd3fc4= 0f6cc933510f676