unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chris Marusich <cmmarusich@gmail.com>
To: "Vagrant Cascadian" <vagrant@debian.org>,
	"Gábor Boskovits" <boskovits@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Making javadoc reproducible
Date: Sat, 13 Oct 2018 20:35:19 -0700	[thread overview]
Message-ID: <87a7nh8ako.fsf@gmail.com> (raw)
In-Reply-To: <87y3b32ehe.fsf@aikidev.net> (Vagrant Cascadian's message of "Fri, 12 Oct 2018 11:42:53 -0700")

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

Hi Gábor and Vagrant,

Vagrant Cascadian <vagrant@debian.org> writes:

> There's been some discussion about this in Debian and in reproducible
> builds:
>
>   https://bugs.debian.org/783938
>
>   https://wiki.debian.org/ReproducibleBuilds/TimestampsInDocumentationGeneratedByJavadoc
>
>   https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_documentation_generated_by_javadoc_issue.html
>
> Hope it's useful!

Thank you for the links!

Gábor Boskovits <boskovits@gmail.com> writes:

> Björn Höfling <bjoern.hoefling@bjoernhoefling.de> ezt írta (időpont:
> 2018. okt. 12., P, 20:01):
>>
>> On Fri, 12 Oct 2018 19:35:51 +0200
>> Gábor Boskovits <boskovits@gmail.com> wrote:
>>
>> > Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
>> > 12., P, 19:00):
>> > >
>> > > Hello guix,
>> > >
>> > > I've tracked down the javadoc timestamp problem.
>> > > There is a command line flag for javadoc (notimestamp), that
>> > > disables generating the comment in the docs that contains the
>> > > timestamp. Currently I see two ways forward:
>> > > 1. Track down the calls to javadoc, and add the flag to all calls.
>> > > 2. Write a simple patch to make javadoc behave as if notimestamp was
>> > > specified, whenever
>> > > SOURCE_DATE_EPOCH is defined.
>> > > I do not think, that the patch produced by 2 is upstreamable, but it
>> > > seems much less work. WDYT?
>> >
>> > Also we can simply turn off the timestamp generation
>> > unconditionally...
>>
>> Number 2 sounds good, and why not giving it a try to place it upstream?
>
> Ok, i will go for it, and try to get it upsreamed for jdk8 and jdk11.

Be sure to check out the links Vagrant posted.  Specifically this one:

https://bugs.debian.org/783938

In that bug report, Samuel Thibault says: "Perhaps javadoc could be made
to use by default the SOURCE_DATE_EPOCH environment variable when it is
defined?"  There seems to be agreement that teaching javadoc to honor
the SOURCE_DATE_EPOCH environment variable would be preferable to
unconditionally disabling the timestamp behavior.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2018-10-14  3:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 17:00 Making javadoc reproducible Gábor Boskovits
2018-10-12 17:35 ` Gábor Boskovits
2018-10-12 18:01   ` Björn Höfling
2018-10-12 18:14     ` Gábor Boskovits
2019-05-19  9:57       ` Mykola Nikishov
2019-05-19 13:46         ` Gábor Boskovits
2018-10-12 18:42     ` Vagrant Cascadian
2018-10-13 21:06       ` Alex Vong
2018-10-14  3:35       ` Chris Marusich [this message]
2018-10-14  6:43         ` Gábor Boskovits
2018-10-14 19:19           ` Gábor Boskovits
2018-10-15 10:09 ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7nh8ako.fsf@gmail.com \
    --to=cmmarusich@gmail.com \
    --cc=boskovits@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).