* Duplicate package in lisp-xyz
@ 2021-05-07 9:15 Guillaume Le Vaillant
2021-05-07 9:43 ` Pierre Neidhardt
0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Le Vaillant @ 2021-05-07 9:15 UTC (permalink / raw)
To: Pierre Neidhardt; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
Hi Pierre,
One of your recent commits (22796f1ad16abb7b1519d11332175d147ae10b82)
adds pathname-utils to "lisp-xyz.scm", however there was already
a definition for this package (starting at line 16030).
As far as I can see it doesn't break anything because the previous
definition is just shadowed by the new one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Duplicate package in lisp-xyz
2021-05-07 9:15 Duplicate package in lisp-xyz Guillaume Le Vaillant
@ 2021-05-07 9:43 ` Pierre Neidhardt
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Neidhardt @ 2021-05-07 9:43 UTC (permalink / raw)
To: Guillaume Le Vaillant; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
Duh! I'm so sorry about this. I had check some days (weeks?) ago, saw
it wasn't there, prepared the package then rebased. In the meantime
Sharlatan had committed it too!
Maybe we could have a `make` or `guix lint` warning for this kind of
things, I suppose they are bound to happen in the *-xyz files.
I'll revert my commit.
I'll be more careful about this pitfall next time, and thanks for
catching this!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-07 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 9:15 Duplicate package in lisp-xyz Guillaume Le Vaillant
2021-05-07 9:43 ` Pierre Neidhardt
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).