From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KLTAF6rTb2Hr9wAAgWs5BA (envelope-from ) for ; Wed, 20 Oct 2021 10:30:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EJN2E6rTb2EcIgAAB5/wlQ (envelope-from ) for ; Wed, 20 Oct 2021 08:30:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 113078D5E for ; Wed, 20 Oct 2021 10:30:33 +0200 (CEST) Received: from localhost ([::1]:37276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6zY-0004KS-UC for larch@yhetil.org; Wed, 20 Oct 2021 04:30:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6yz-0004Gl-6p for guix-devel@gnu.org; Wed, 20 Oct 2021 04:29:57 -0400 Received: from ns13.heimat.it ([46.4.214.66]:50656) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6yx-0003yV-IF for guix-devel@gnu.org; Wed, 20 Oct 2021 04:29:56 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id D6A353021BC; Wed, 20 Oct 2021 08:29:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LmyhYafEk7gE; Wed, 20 Oct 2021 08:29:34 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.162.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 316D23021BA; Wed, 20 Oct 2021 08:29:34 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id AD8DE13DA432; Wed, 20 Oct 2021 10:29:33 +0200 (CEST) Received: (nullmailer pid 5625 invoked by uid 1000); Wed, 20 Oct 2021 08:29:32 -0000 From: Giovanni Biscuolo To: zimoun , Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-devel@gnu.org Subject: patches for new packages proper workflow (Re: Tricking peer review) In-Reply-To: <86ee8hfm1k.fsf@gmail.com> Organization: Xelera.eu References: <874k9if7am.fsf@inria.fr> <86ee8hfm1k.fsf@gmail.com> Date: Wed, 20 Oct 2021 10:29:32 +0200 Message-ID: <87a6j4m74j.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634718634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=4tV1bn/uxWD4OoATvlRHEfei7/CMTMh+DmR+n71DaIw=; b=XR7t86H5UzyT8SEcHUNl32Vfb1QlORcURnF3EEDBkDaw6kzb110+Lym3TGe2m2X6JVh5DV 6kMZo4RY5fLxgJQvHlZ45rM5ryl1MVvd8xBz4xFP8BdX56wEARz75etvvs+AFmuYr+gMJE qFWatvgIzAKO/Nw02hN84hR5dMXYn+zoVRvDULfVhZFEw80dAeJPNknwGzfopm5adyCQT3 jD9H3PYBsEZUVMgZi5esPPWxQTaIkMd3VN0yukuSHUzHPT2lRZQQxvzn39ZNKQqmXrWfIB AyNyr43+065YmoeakYMOY9R1cyumoj6MkE58zG7lL5A+pHRtcnrAeIwkkRhJxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634718634; a=rsa-sha256; cv=none; b=r8YzfpJuPoZhSxaVSJCqdDarZVikuyXGhSXBqozkLLcmWjNCliAXnlyWW5TCZWj26qfELd R1z36af6LdL4XeJFt7KmBNfLBHdAifuSQrwpfZi8GX/u9+lavMb/PtiSGQVTkTkjZopKG+ reGXq91d37Bcxp8xiPj62VElrGJmCoeANCNhSjU4nr3Zl4dnNgPbl1C40wZ7CA57l9RFRL N+g72ScdPTWsvx1CP9Rmf25Wj8uyap2Ty2bo/ilB0EGy25fpY59VjUvXYa3sh8p2f9F1w7 TF1uaDqaQaoXTssWXRg16pk9nWQpVy60q9aFkQbUVoHXZPZO77o4Ot7dPedEOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 113078D5E X-Spam-Score: -4.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: RhwbAB9kVjIz --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, zimoun writes: [...] >> All in all, it=E2=80=99s probably not as worrisome as it first seems. H= owever, >> it=E2=80=99s worth keeping in mind when reviewing a package. > > I agree with a minor comment. From my opinion, not enough patches are > going via guix-patches and are pushed directly. > > For instance, the =C2=ABCommit policy=C2=BB section says =C2=ABFor patche= s that just > add a new package, and a simple one, it=E2=80=99s OK to commit, if you=E2= =80=99re > confident (which means you successfully built it in a chroot setup, and > have done a reasonable copyright and license auditing).=C2=BB > > And from my point of view, new packages should *always* go via > guix-patches, wait 15 days, then push if no remark. It lets the time > for the community to chime in. And if not, it just slows down for 2 > weeks. I agree with Simon, the policy to add new packages should be changed as he proposes. Thanks! Giovanni =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmFv02wMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkS7c8P/iTkY7u7K5lbQvhMBpum2BDOEIjWLKjr2piTZZ4Z oGfZWFy7meV9ZNbRrluEB2djz/3Pf2mhMMI/sQwXsNPsw5Weq8cNmJDbvcQHA8Nt q8lIxOcJ1/R5Ptov9VIxdIV8o4K/1Uy8Ek5Cm8p0q+hfbzke02DPk5MR3ZR8Og2a jwGLVR/RGNKGcIogFnWFNSoUTceQDqSvOoeIhsRpRmxTQZDmD0A7UJ4jIxzEhlAZ slL1S5KguzXqW9b+VpGywdu9LDW28fdmdeadoKtmFa95rErNyWAI0ez5UE4c34NQ 2AC+jRWbLNR9d16lYKC/3vhyFUYH/ek9XcjeL4jg3uT52cQPNZ/NOKpEmA5cRDCu ntGhz3Cj/ts1AzIxEjWAGy4wN6Yt1KFqXMCDJwzBT5py220V161SBW89pYtK54+d ssNrToGqhvBQJKtHWKxFKPo5Vgf+tLyBZlA/oXKRx5o9YMVoWJtB46Dt1h6CPtjH ZP39Ylvckh5Hhu/ryvucN+wnHw6UaLfUlpf53HbPYuzYgzjlygPjllZZbZuU/e9v eUy5OnNVUMrA0YDfSePZSu0DFfs6jTw1Uy9GVkeii5cKkWVVwN79mxvES8lu0lx+ f6k2N+JOiUfvxRddnWwvNJwhJzJiMNyqSHaxoiByzDLUrF7DZWr503SRg7fZrHtw MTJu =bwua -----END PGP SIGNATURE----- --=-=-=--