From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ZbLiN4zke2EbGwEAgWs5BA (envelope-from ) for ; Fri, 29 Oct 2021 14:09:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yE0CM4zke2E2agAAB5/wlQ (envelope-from ) for ; Fri, 29 Oct 2021 12:09:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A6B0329121 for ; Fri, 29 Oct 2021 14:09:48 +0200 (CEST) Received: from localhost ([::1]:45940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgQhf-0004j6-Rv for larch@yhetil.org; Fri, 29 Oct 2021 08:09:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgQhV-0004in-0p for guix-devel@gnu.org; Fri, 29 Oct 2021 08:09:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgQhU-00034V-Im; Fri, 29 Oct 2021 08:09:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=kZRCH3B/qLUlhk8tUvXcuGyTPiMRPDs3QD8hVYBYf8s=; b=ByF0Hdx1WRAOKd5ZaedD qQ4uq9mR8C1QgVdHK9xhBUgRni3ERn76ZihIFFRqt/REhfDmYvMRfMlJj+sDSbXygVAwrqj5d4WMF 6Uv6UcM5B2t1qvIoR+03l9x6ZheJzZ576yPUV5qW6i28dfDtg8BG9Qc7CjjO/fgx9N89CgOWNEco9 or++QUPptAEQg2fGe8+rbP181gKmLXDIvi8I7z2dQgnke3kkxYLA0NoYbzzH/nWO2KNIH7fSwLZgn 5blwn8FhdIDxReiWErIWb/lXazvX8dE+XeSEgILM5we28RdrqF/iSSYXsiydmnQQ7K4ly0MDc+i/9 DEuOYW4/L0hLGg==; Received: from [193.50.110.158] (port=55572 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgQhU-0000z8-5u; Fri, 29 Oct 2021 08:09:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Greg Hogan Subject: Re: Test parallelism with CMake References: <3906845baca1424432c1fd5c3ab23c1400695b66.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Brumaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 29 Oct 2021 14:09:34 +0200 In-Reply-To: (Greg Hogan's message of "Fri, 22 Oct 2021 09:10:56 -0400") Message-ID: <87a6is2fsx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Liliana Marie Prikler Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635509388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=kZRCH3B/qLUlhk8tUvXcuGyTPiMRPDs3QD8hVYBYf8s=; b=LZfdvJnyHRVkJvTPQSYmT4c1kGAKGTM1klgF9GhU+nHPiU2gOEVBPhbye1F+1etxUryvS9 ymT51VltktvHzHSOyP6vBgnp3bTWNpc2St+BKtY3yvnsGHwHYnLbeewjeFrKqFDlpMK/wi z+rp4bk8MYy+ixKpTUXcTw1dHZqmxf5DaWpv/gGOzXKpfGa/Zxv2X4Qdpe+zmkAupLUU0z VE+L+ukx/vqwBIjhp9v2L7KeMr3bnr/qIukJUl485IcDEhH0R2UzpLo76g803zPj/JnhXA Tula6QIdAuRzpi8FxTzQipy87nRsaF6oesGL/aKIYFndtnX9j9Zv821V0nIK5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635509388; a=rsa-sha256; cv=none; b=L2uSeUPAzqhwIkoCQOekMags8yiKA3PgJgUZHLN+EQO9PCyRqjF/GjksnFN+Y4KCENvqqJ slvPOCUMgqZzDlPIT2tKUTYsC0EgE46rP5L5YCdxX1tX0NeU8P27Fd6v/SsyAAj/kFBh+S ubkp2i5WKrg21CfKqH4c+5w6t3waNIsQLaJIeWDJgqP5ZBNBuUPWs7ZELSvwAwRAeHNWqD s71ADRKcw5Gmhnhse3jDgu6j3HbPOyJ7uWSX7lwLvMh6Y5v6S9vHoSn6FXOwgTv/lkUg02 g8iJF1VpILRjvA4n1CFtMts86xlUTgQEsTGbOZup8uZPOeojtojetWWXh9oJZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=ByF0Hdx1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=ByF0Hdx1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A6B0329121 X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: XCsNNBF3vFzb Hi Greg, Greg Hogan skribis: > The cmake-build-system does defer to gnu-build-system, which calls `make > test -jN`; however, CMake generated Makefile specifies 'test' as a single > target (the Ninja generator suffers from the same issue) so `ctest` is run > without parallelism. > > To run CMake tests with parallelism the cmake-build-system should directly > call `ctest` with the configured parallelism (same '-jN' argument). The > cmake-build-system's check method is essentially untouched from March, 20= 13 > (commit c6bded8a) so this issue has existed from the beginning. OK, got it. > I made an inelegant patch to my local guix repo, essentially replacing > cmake-build-system:check with a copy of gnu-build-system:check and changi= ng > 'apply invoke "make" test-target' to 'apply invoke "ctest"'. This works, > although the package I was working on requires parallel tests to be > disabled. Once the expectation is set that code will be run serially it is > difficult to change the default to parallel execution. > > It seems that we should at a minimum document the issue in > cmake-build-system:check. We could patch cmake-build-system to enable test > parallelism and explicitly disable that setting for packages which succeed > before but fail after making the change. What do you think? I think we could make the change you made=E2=80=94running =E2=80=98ctest=E2= =80=99=E2=80=94in =E2=80=98core-updates=E2=80=99. If it turns out to be safer, we can have #:parallel-build? default to #f at the beginning in =E2=80=98cmake-build-system=E2=80=99. How does that sound? Thanks, Ludo=E2=80=99.