From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8MpBJqecm2ETUAAAgWs5BA (envelope-from ) for ; Mon, 22 Nov 2021 14:35:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6PTxIaecm2EcLgAAB5/wlQ (envelope-from ) for ; Mon, 22 Nov 2021 13:35:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 474EA210C1 for ; Mon, 22 Nov 2021 14:35:35 +0100 (CET) Received: from localhost ([::1]:39452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mp9To-0005Vs-P2 for larch@yhetil.org; Mon, 22 Nov 2021 08:35:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp9PA-0003HJ-Ni for guix-devel@gnu.org; Mon, 22 Nov 2021 08:30:44 -0500 Received: from [2001:470:142:3::e] (port=60684 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp9PA-0000l8-DN; Mon, 22 Nov 2021 08:30:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zI/uJaXIKxBD//n53/yQzWsS3RNWqv+O7WVVKSAOmSU=; b=kcApQtmcfc6rVKG3KT1Y wBVdINz3JXEZOzy3LEIX+0Wjc22+uBYS7veR+fXEAeneII0+fjqw/FgP8BP8+1hIIRmpIZhQGXGhK Y49IWph8iH+7qkITpa+xe49zRj9m7uErKYf5LadEWs8XoQB0tIeofaFWGPXTMno60VUkPxzQSxJ9w S7nTK6aQfHx/MhFAqjdehT/kSMfzSzHK2PiqGIXQcURZfReaLlCXWfflLpjAtWtVcSAQ038iIAhBw UCw+NO5SZeEgjsqo/pZ+vlXD4Uqz+3oBXwe/quNaf9qsH6dP6hSff2NrYb2mpfB5FP5gLhHne4w5t 2SVmMXJ6B3qxmA==; Received: from [193.50.110.200] (port=54064 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp9PA-0008Pi-6M; Mon, 22 Nov 2021 08:30:44 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: Replacing polkit by polkit-duktape on core-updates-frozen ? References: <87k0hetuty.fsf@gmail.com> <2505829.NYjHvEFHQz@popigai> <87v90rxcnr.fsf@gnu.org> <87mtlwc175.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Frimaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 22 Nov 2021 14:30:40 +0100 In-Reply-To: <87mtlwc175.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 21 Nov 2021 22:35:10 -0500") Message-ID: <87a6hwnwqn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637588135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=zI/uJaXIKxBD//n53/yQzWsS3RNWqv+O7WVVKSAOmSU=; b=AnBhOu7QU3dycTkOkEfrhjzW3/JP1/kw/yskBk8d2Vz+jMrbN5JQKNdw4Z/FVr98MkWdBm mQiLzi2o0vUZ6RUGrkGTxqZKJDdS8SxdXl3stnjI4q4yLucsFx4zPRh54Op1M+wourXuHx XMmwQJDkPDWsBrD1RqvZXTgG1Ej85bmQVbArAFFtFByBqa+I4+M7yyOv4td5JgTy6N/Q4r QCbiaeM9vDxH+0MXwxdQKq8N7DDP5t0bhg/Inx8mDa+as9bMTJRfhL7ohqfSWFEKeYfwxM qPSi0V4mSPVtSemPcGWEIcaGNExUdqu/HyQRfOtiaXAkrPmE3ms58MlBeCPZzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637588135; a=rsa-sha256; cv=none; b=oEnip/1KfZroM7dVj5BWeJZ9lGYDPTRhPXlllG1o60++0O4PMYDxUyW+Ktm7JIAi8xDOii uzWk/oV3Jmq4/kqoNztXTC5hOb4HMXsDdVyccgMSRdRh1QOI/8atrIshmB751j8/ksLm/2 1TR380Mvfbrx8t2DIKxnGvH09HuES+98DwB67pEAfhdTOII1Um54VWvZudURWBL9Brq4va 3TRkC7rJvQ7FlYYpvBatY72ZhzbR1604wcbwelvx1BPud7C6ZYQ66WaXlWyhgS7IVaFd48 DdOQnIlL1PdDtM+m/4GE16PQgmWFXfs1VLZMRFE46uLsPTJ5j12uDIh/qP4x3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=kcApQtmc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.28 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=kcApQtmc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 474EA210C1 X-Spam-Score: -4.28 X-Migadu-Scanner: scn0.migadu.com X-TUID: wrO/TGABA57E Hi Maxim, Maxim Cournoyer skribis: > +;;; Define a top level polkit variable that can be built on any of the > +;;; supported platforms. This is to work around the fact that our > +;;; mrustc-bootstrapped rust toolchain currently only supports the x86_64 > +;;; architecture... > +(define-public polkit > + (if (string-prefix? "x86_64" > + (or (%current-system) (%current-target-system))) > + polkit* > + polkit-duktape)) This would instead have to be a macro, similar to the =E2=80=98pkg-config= =E2=80=99 macro, so that (%current-system) is checked at the right time rather than when loading this module. However, since the only different between polkit and polkit-duktape (IIUC) is that an extra patch is applied for the latter, I would instead suggest adding a conditional build phase that applies the patch on non-x86_64 systems. How does that sound? Ludo=E2=80=99.