From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Replacing polkit by polkit-duktape on core-updates-frozen ?
Date: Mon, 22 Nov 2021 14:30:40 +0100 [thread overview]
Message-ID: <87a6hwnwqn.fsf@gnu.org> (raw)
In-Reply-To: <87mtlwc175.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 21 Nov 2021 22:35:10 -0500")
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> +;;; Define a top level polkit variable that can be built on any of the
> +;;; supported platforms. This is to work around the fact that our
> +;;; mrustc-bootstrapped rust toolchain currently only supports the x86_64
> +;;; architecture...
> +(define-public polkit
> + (if (string-prefix? "x86_64"
> + (or (%current-system) (%current-target-system)))
> + polkit*
> + polkit-duktape))
This would instead have to be a macro, similar to the ‘pkg-config’
macro, so that (%current-system) is checked at the right time rather
than when loading this module.
However, since the only different between polkit and polkit-duktape
(IIUC) is that an extra patch is applied for the latter, I would instead
suggest adding a conditional build phase that applies the patch on
non-x86_64 systems.
How does that sound?
Ludo’.
next prev parent reply other threads:[~2021-11-22 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 18:23 Replacing polkit by polkit-duktape on core-updates-frozen ? Maxim Cournoyer
2021-11-11 23:30 ` Thiago Jung Bauermann
2021-11-17 11:08 ` Ludovic Courtès
2021-11-22 3:35 ` Maxim Cournoyer
2021-11-22 13:30 ` Ludovic Courtès [this message]
2021-11-22 20:26 ` Maxim Cournoyer
2021-11-22 20:41 ` Maxim Cournoyer
2021-11-23 17:18 ` Ludovic Courtès
2021-11-23 20:34 ` Thiago Jung Bauermann
2021-11-24 4:11 ` Maxim Cournoyer
2021-11-24 4:02 ` Maxim Cournoyer
2021-11-24 8:42 ` Josselin Poiret via Development of GNU Guix and the GNU System distribution.
2021-11-24 14:42 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6hwnwqn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).