From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id INN7Dnsa/2TKMAEA9RJhRA:P1 (envelope-from ) for ; Mon, 11 Sep 2023 15:47:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id INN7Dnsa/2TKMAEA9RJhRA (envelope-from ) for ; Mon, 11 Sep 2023 15:47:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB3E35591F for ; Mon, 11 Sep 2023 15:47:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bA2EEbro; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694440059; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ZqSALeK4EpU+sBdHG7fIS6bZz8vHmoZ1g6ZypV1DIO0=; b=arxcjNaZPj6RJrQjp1xaKuVOtzumHhgLMHdvX5YBScF58taSh3GNyJ13L61NHeOEqgE23F tgtc0teh4fuEBCaoejaG2jSOr1Cb57U+XFUKYy2CenexQhkL62S/D0koXInjRtb5zMIAs/ khk9PldPyuE7I/nJAU2M9THA+CQ0SYT5zlZ5zML3PkCkzMn5PmPsZWtx7vbUnuahtRrkAF 1x9n8S2gUBDw9pQc5GqCnDNjs9HIUlyxFcE6L0T9i0KUhkZasQpGNUCMQcoik39ILE/Gqy o/8Q5YaioB5aAMQ4WJEzShQ7eMzAlaBSj6hOEi9505QgWuG8WTlwhdNqKfOyow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694440059; a=rsa-sha256; cv=none; b=n7qeemU1Q6so9H8ogT9bzJyjk1p3AXaFOSizO0XkXsoDIQM65am+vPvIeZRQIL9NvJJZj/ I67ooPO38m1y5DCDl9c8ZBFMOwDoM3GPHsRNdtM43Bi9qwR6HdebxuaJJt6l/X2tYvX0Gb yEWJeaLkoJT/JTCY4Ugr9KglJBkXz4zz3KdHtC6eio2L9gxkIvg7E45E3tYBDBx7iujAoj +1eqTKsmBNUWbkKak6q+jjJDhF70Ox5iiXYnQtnoumexr8ipGuC2rTDj0DHmHMGSnDMee6 7ovaugMns9xh0hHl9Uc2BGdhjLfbBYukG98DNCH2FPkIV5CdokU52lXEok8HHw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bA2EEbro; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfhFr-0003Er-Ew; Mon, 11 Sep 2023 09:47:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfhFp-0003ER-C1 for guix-devel@gnu.org; Mon, 11 Sep 2023 09:47:05 -0400 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfhFn-0001i7-3S for guix-devel@gnu.org; Mon, 11 Sep 2023 09:47:05 -0400 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6c0b3cea424so2905050a34.2 for ; Mon, 11 Sep 2023 06:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694440021; x=1695044821; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ZqSALeK4EpU+sBdHG7fIS6bZz8vHmoZ1g6ZypV1DIO0=; b=bA2EEbroFg3NJylxY0fc+cGXVvoYIBFfBf/FwYco5Ae+UMaBxAlnViR0ru1Cffdo8D menv2hmi/z++RPYJe7qrSJBbzKIht4k9tAuUV1iubA7kwXndEGnL8eZ3lrlldncMTE3D kW+ekB0zjJL8uTmIzkN+aMnTRebE3pzSdII8IkZ1MyD+IMyRXouCGWGLDefzRI4q/3bO md8uX2Axa5Ac6dkly3/6uY+qAUgm6LfQ6lQ2SE0fBjs4fcBGkR8/PiFbiqDD/CfdbfpI TeaHY8rM+UobY0uduQt9SF/5tIYRcZ3Se+nFU/oLS/2L1SE/5dHZOonbqYQWfBoCcLsl kfEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694440021; x=1695044821; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZqSALeK4EpU+sBdHG7fIS6bZz8vHmoZ1g6ZypV1DIO0=; b=LWCHZfs+Kjav74C6m4XABxWEpW1ZQTA25BqVFZxYnzDMuXJV/QgYat9rmKfHLocD98 G4LmZcFSx40YCGBujBLprDd5DZThrp+1ccMOUZ8FPmIZlgK1ocxw6epLWmTyYSRThbKu Q42404mAmsArCQLyO+vc4fKxj4F0Yrd1VrvY95QYOUOlCO/yZyUwKkBGuqBdCmj3v737 ybJ3xYhLnHbhshd2ikRYH07dRrt2MHQ/xHNydRSHh8gUlC7+qAY8p8grjzJMjQszDlgr kBj6k4vq25GbjihZACUdHZg2JaoYeAfTdZs6CMSXBvYGm6kfvYwk522/GDmOO+hATHSD lqhw== X-Gm-Message-State: AOJu0YzJd6rAPM+8sc0FivA3fmOqzZKfBrERMP/FK5dKACl7N7Dji1FV UZx2Ge7mcyQW/VqmC+MCRBpt3QKqWs8= X-Google-Smtp-Source: AGHT+IFPmejnTI9rp4S52F64a5dCPCdznhyKPkI3m+W17YfS36R7tNTZDn3vZqMzaLj+X5K5Mkv+UQ== X-Received: by 2002:a05:6358:d00d:b0:141:1e2:2e6a with SMTP id ja13-20020a056358d00d00b0014101e22e6amr3220606rwb.14.1694440021153; Mon, 11 Sep 2023 06:47:01 -0700 (PDT) Received: from hurd (dsl-141-150.b2b2c.ca. [66.158.141.150]) by smtp.gmail.com with ESMTPSA id a14-20020a0ccdce000000b00655e3e86ad7sm1322088qvn.6.2023.09.11.06.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 06:47:00 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Cc: Vagrant Cascadian , Felix Lechner , Giovanni Biscuolo , guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <86o7ien856.fsf@gmail.com> <87h6o6fdgv.fsf@xelera.eu> <877cp2nn91.fsf@gmail.com> <871qfam14v.fsf@wireframe> <87ledex5xr.fsf@gmail.com> <87bke9j7pk.fsf@gmail.com> Date: Mon, 11 Sep 2023 09:46:58 -0400 In-Reply-To: <87bke9j7pk.fsf@gmail.com> (Simon Tournier's message of "Mon, 11 Sep 2023 13:00:07 +0200") Message-ID: <87a5tszust.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=maxim.cournoyer@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.15 X-Spam-Score: -8.15 X-Migadu-Queue-Id: EB3E35591F X-Migadu-Scanner: mx0.migadu.com X-TUID: v6s5bWIFKHTe Hi Simon, Simon Tournier writes: > Hi Maxim, > > On Sat, 09 Sep 2023 at 19:50, Maxim Cournoyer = wrote: > >>>> --8<---------------cut here---------------start------------->8--- >>>> random=3D$({ git var GIT_COMMITTER_IDENT ; echo "$refhash" ; cat "$1";= } | >>>> git hash-object --stdin) >>>> --8<---------------cut here---------------end--------------->8--- >>> >>> That seems like it would only work if the patch was identical, as >>> opposed to a slightly rebased patch on top of newer patches on master? >>> >>> How can you correlate Change-Id to a patch in the tracker? >> >> The Change-Id stays the same unless you manually edit it out of your >> commit message when amending / rebasing, so the commit hash may change >> while the Change-Id stays the same. So you can rebase your feature >> branch on master and share a v2, whose existing commits will have the >> same Change-Ids (newly added commits would get their own Change-Id >> trailer). > > I am sorry if I am slow but I do not understand. > > $ git var GIT_COMMITTER_IDENT > Simon Tournier 1694428674 +0200 > $ git var GIT_COMMITTER_IDENT > Simon Tournier 1694428800 +0200 > > Therefore this Change-Id can be different for the same series, depending > when I am locally committing. No? > > And sorry if I am slow but I am also missing your answer about =E2=80=9CH= ow can > you correlate Change-Id to a patch in the tracker?=E2=80=9D. How is this > Change-Id correlated to the Debbugs number? The commit hook job is simple: generate a unique ID. The magic is that it only adds it *once* to a commit message; if it finds the 'Change-Id:' line already present in it, it won't refresh its value or add a new one. So it's immutable once added, preserved in the Git commit message itself. > Let take an example. :-) Assume Change-Id was used for your submission > bug#65280 about Qt. It reads many patches and we have: > > 02/59 > 1717c8a233b7fda3a10aabc061168c71317f883e > AuthorDate: Fri Aug 11 15:26:14 2023 -0400 > > 59/59 > 0a77b869322274030c4c0e8315ddea802da44c92 > AuthorDate: Tue Aug 15 16:20:10 2023 -0400 > > From my understanding, > > 1. GIT_COMMITTER_IDENT depends on time so these two commits would have > a different Change-Id, no? Correct. The commit hook adds a unique ID *per* commit. > 2. How is Change-Id linked to #65280? Each patch submission ("issue") can have one or multiple commits. We'd know for sure the series was merged (and thus can be closed) when the set of 'Change-Id's its commits contains have all appeared in the master branch. The mapping of Debbugs ID <-> set(change-ids) would need to be established by an external tool such as Mumi (which I think is in a good position to do so). I hope that helps! --=20 Thanks, Maxim