unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christian Miller <christian.miller@dadoes.de>,
	Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: Check for ANSI compliance
Date: Mon, 29 Jan 2024 17:44:16 +0100	[thread overview]
Message-ID: <87a5oom6n3.fsf@gnu.org> (raw)
In-Reply-To: <87cytz7qzh.fsf@dadoes.de> (Christian Miller's message of "Wed, 17 Jan 2024 19:29:54 +0100")

Hi,

Christian Miller <christian.miller@dadoes.de> skribis:

> I use the Emacs compilation mode (M-x compile).
>
> For example, the following "M-x compile RET guix build does-not-exist
> RET" would result to the following:
>
> -*- mode: compilation; default-directory: "~/" -*-
> Compilation started at Wed Jan 17 19:18:57
>
> guix build does-not-exist
> guix build: error: does-not-exist: unknown package
>
> Compilation exited abnormally with code 1 at Wed Jan 17 19:18:57
>
> It is not only visually, but it actually breaks a feature of the mode,
> too.  The unknown package error is not detected as an error by the
> mode.  I also had a case where it detected warnings as errors.
>
> Could we check for ANSI compliance instead of assuming it's presence?

That used to be the case until commit
672d3d4a87839b0692c307df0edb66cd16bcbf1a, which enabled colors even when
‘INSIDE_EMACS’ is set.

Pierre, do you remember what the rationale was?

Ludo’.


  reply	other threads:[~2024-01-29 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 18:29 Check for ANSI compliance Christian Miller
2024-01-29 16:44 ` Ludovic Courtès [this message]
2024-03-08 18:07   ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5oom6n3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=christian.miller@dadoes.de \
    --cc=guix-devel@gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).