From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cook.
Date: Sat, 14 Jun 2014 22:07:35 +0200 [thread overview]
Message-ID: <878uozi7aw.fsf@gnu.org> (raw)
In-Reply-To: <1402769510-31041-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Sat, 14 Jun 2014 20:11:50 +0200")
John Darrington <jmd@gnu.org> skribis:
> * gnu/packages/cook.scm: New file.
> * gnu-system.am: New file cook.scm.
Looks good!
> + (arguments
> + `(#:parallel-build? #f ;; There are some nasty racy rules in the Makefile
One semicolon only; period at the end.
> + #:phases
> + (alist-cons-before
> + 'configure 'pre-conf
> + (lambda _
> + (substitute* (append '("common/env.c")
^^
2 extra indentation spaces here.
> + ;; Guix's binutils is (for undeclared reasons) configured with the
> + ;; --enable-deterministic-archives flag. This has odd effects on
This is because we want bit-reproducible builds in general, and being
able to build archives deterministically is one aspect of that. Related
issues are discussed at <https://wiki.debian.org/ReproducibleBuilds> and
<https://lists.gnu.org/archive/html/guix-devel/2013-09/msg00159.html>.
Thus, could you remove “(for undeclared reasons)”? :-)
OK to push with those changes.
Ludo’.
prev parent reply other threads:[~2014-06-14 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 18:11 [PATCH] gnu: Add cook John Darrington
2014-06-14 20:07 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uozi7aw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).