Re: [PATCH] Add dcfldd

[Mark H Weaver <mhw@netris.org>]

"Bishmer J. Sekaran" <bishmer@scorpionrock.com> writes:

> Oops, corrected homepage.
>
> On 08/04/14 11:25, Bishmer J. Sekaran wrote:
>>  From fadbb3a11b972499e4fe5a2f6ec69c98b387ecc7 Mon Sep 17 00:00:00 2001
>> From: "Bishmer J. Sekaran" <bishmer@scorpionrock.com>
>> Date: Mon, 4 Aug 2014 19:21:23 +0800
>> Subject: [PATCH] [PATCH] Add dcfldd
>>
>> ---

This needs a proper commit message.  Please look at our git logs for
examples.

>>   gnu-system.am           |  1 +
>>   gnu/packages/dcfldd.scm | 51
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>   create mode 100644 gnu/packages/dcfldd.scm
>>
>> diff --git a/gnu-system.am b/gnu-system.am
>> index 6e1e8af..346cbe5 100644
>> --- a/gnu-system.am
>> +++ b/gnu-system.am
>> @@ -67,6 +67,7 @@ GNU_SYSTEM_MODULES =				\
>>     gnu/packages/cyrus-sasl.scm			\
>>     gnu/packages/datamash.scm			\
>>     gnu/packages/dc.scm				\
>> +  gnu/packages/dcfldd.scm			\
>>     gnu/packages/dejagnu.scm			\
>>     gnu/packages/dictionaries.scm			\
>>     gnu/packages/disk.scm				\
>> diff --git a/gnu/packages/dcfldd.scm b/gnu/packages/dcfldd.scm
>> new file mode 100644
>> index 0000000..451a212
>> --- /dev/null
>> +++ b/gnu/packages/dcfldd.scm
>> @@ -0,0 +1,51 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
>> +;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
>> +;;; Copyright © 2014 Bishmer J. Sekaran <bishmer@scorpionrock.com>

Since you created this file, it should only be copyrighted by you.
Also, it seems that the patch has been munged by your mail client.

* Although the content is in UTF-8, the mail headers say it is encoded
  in windows-1252, so the non-ASCII characters are all corrupted.

* It has been word-wrapped, so it's no longer a valid patch.

Maybe try sending the file as an attachment instead?

>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages dcfldd)
>> +  #:use-module (guix licenses)
>> +  #:use-module (gnu packages gnutls)
>> +  #:use-module (gnu packages perl)
>> +  #:use-module (guix packages)
>> +  #:use-module (guix download)
>> +  #:use-module (guix build-system gnu))
>> +
>> +(define-public dcfldd
>> +  (package
>> +    (name "dcfldd")
>> +    (version "1.3.4-1")
>> +    (source
>> +     (origin
>> +      (method url-fetch)
>> +      (uri (string-append
>> "http://nchc.dl.sourceforge.net/project/dcfldd/dcfldd/1.3.4-1/dcfldd-"
>> +                          version ".tar.gz"))

As Andreas mentioned, this URI should use Guix's "mirror://" syntax so
that it automatically chooses from several known mirrors.

>> +      (sha256
>> +       (base32
>> +        "1y6mwsvm75f5jzxsjjk0yhf8xnpmz6y8qvcxfandavx59lc3l57m"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("gnutls" ,gnutls)))
>> +    (native-inputs
>> +     `(("perl" ,perl)))
>> +    (home-page "http://dcfldd.sourceforge.net/")
>> +    (synopsis "A version of dd with a progress indicator and other
>> features")
>> +    (description
>> +     "Created by the US Department of Defence's Computer Forensics
>> Laboratory, dcfldd is an enhanced version of GNU dd with features
>> + useful for forensics and security.")
>> +    (license gpl2)))
>>

Is the license really gpl2 and not gpl2+?

    Thanks,
      Mark