From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Kernel Configuration
Date: Thu, 25 Sep 2014 00:05:36 +0200
Message-ID: <878ul8znbj.fsf@gnu.org>
References: <1411592014.19369@bluehome.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XWuh3-0003n6-13
	for guix-devel@gnu.org; Wed, 24 Sep 2014 18:05:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XWugw-0002DF-Ik
	for guix-devel@gnu.org; Wed, 24 Sep 2014 18:05:48 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:56351)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XWugw-0002Ch-5T
	for guix-devel@gnu.org; Wed, 24 Sep 2014 18:05:42 -0400
In-Reply-To: <1411592014.19369@bluehome.net> (Jason Self's message of "Wed, 24
	Sep 2014 13:53:36 -0700 (PDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Jason Self <jason@bluehome.net>
Cc: guix-devel@gnu.org

"Jason Self" <jason@bluehome.net> skribis:

> Hello, I wanted to make sure that I was doing this correctly before
> committing anything. It seems that it's best to have all of the
> kernel's config stuff centrally located. Plus, all of these are
> already enabled in the normal config,

If we are sure there are no changes for these options, this is fine with
me (the current settings are relied on by (gnu system vm).)

> and I'd argue in a better way.  For example: CONFIG_VIRTIO_BLK should
> be built in, not a module. Doing it as a module can cause difficulties
> when running in a VM in some cases and the normal config already has
> it as a built-in.

It doesn=E2=80=99t cause any problems in practice: the #:virtio? parameter =
of
=E2=80=98base-initrd=E2=80=99 makes sure that module is loaded early (see
gnu/system/linux-initrd.scm.)

Furthermore I would rather keep CONFIG_VIRTIO_BLK=3Dm rather than =3Dy
precisely because that module only makes sense when running a QEMU
guest and not otherwise.

WDYT?

> From aec034aab287ce3ba84139be6f773d0a6144f2f1 Mon Sep 17 00:00:00 2001
> From: Jason Self <j@jxself.org>
> Date: Wed, 24 Sep 2014 11:37:37 -0700
> Subject: [PATCH 1/1] gnu: linux-libre: Configuration options should be
>  specified in the configuration file.

Rather =E2=80=9Cgnu: linux-libre: Do not set config options in the build ph=
ase.=E2=80=9D

> * gnu/packages/linux.scm (linux-libre): Configuration options should be s=
pecified in the configuration file.

=E2=80=9CRemove config option settings from =E2=80=98build-phase=E2=80=99.=
=E2=80=9D

Thanks,
Ludo=E2=80=99.