Re: [PATCH] Kernel Configuration

[ludo@gnu.org (Ludovic Courtès)]

"Jason Self" <jason@bluehome.net> skribis:

> Hello, I wanted to make sure that I was doing this correctly before
> committing anything. It seems that it's best to have all of the
> kernel's config stuff centrally located. Plus, all of these are
> already enabled in the normal config,

If we are sure there are no changes for these options, this is fine with
me (the current settings are relied on by (gnu system vm).)

> and I'd argue in a better way.  For example: CONFIG_VIRTIO_BLK should
> be built in, not a module. Doing it as a module can cause difficulties
> when running in a VM in some cases and the normal config already has
> it as a built-in.

It doesn’t cause any problems in practice: the #:virtio? parameter of
‘base-initrd’ makes sure that module is loaded early (see
gnu/system/linux-initrd.scm.)

Furthermore I would rather keep CONFIG_VIRTIO_BLK=m rather than =y
precisely because that module only makes sense when running a QEMU
guest and not otherwise.

WDYT?

> From aec034aab287ce3ba84139be6f773d0a6144f2f1 Mon Sep 17 00:00:00 2001
> From: Jason Self <j@jxself.org>
> Date: Wed, 24 Sep 2014 11:37:37 -0700
> Subject: [PATCH 1/1] gnu: linux-libre: Configuration options should be
>  specified in the configuration file.

Rather “gnu: linux-libre: Do not set config options in the build phase.”

> * gnu/packages/linux.scm (linux-libre): Configuration options should be specified in the configuration file.

“Remove config option settings from ‘build-phase’.”

Thanks,
Ludo’.