From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add python2-gnomekeyring.
Date: Tue, 21 Apr 2015 17:59:46 +0200
Message-ID: <878udlh3pp.fsf@gnu.org>
References: <87618s2dtw.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YkaaX-0006tY-2J
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:59:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YkaaT-0003MX-TS
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:59:53 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36927)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YkaaT-0003MT-QM
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:59:49 -0400
In-Reply-To: <87618s2dtw.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Sun, 19 Apr 2015 20:05:47 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> the first patch defines a function to create packages from
> python2-gnome-desktop components and redefines python2-rsvg using this
> function.

Would it make sense to just have python2-gnome-desktop containing
everything, or would that be overkill?  (I suspect the latter, but I
want to make sure.)

> From 9045e6d296593a7f81269ecfab327733853b68f4 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 5 Mar 2015 08:38:13 +0100
> Subject: [PATCH 1/2] gnu: python2-rsvg: Define with helper function.
>
> * gnu/packages/gnome.scm (python2-gnome-desktop-component): New variable.

[...]

> +(define (python2-gnome-desktop-component comp syn desc ins lic)

Please spell out the argument names and add a docstring.

> +    (synopsis syn)
> +    (description desc)
> +    (license lic)))


[...]

> +(define-public python2-rsvg
> +  (python2-gnome-desktop-component
> +   "rsvg"
> +   "Python bindings to librsvg"
> +   "This module contains bindings allowing the use of librsvg in Python."

The problem is that xgettext won=E2=80=99t notice these.

A little bit of extra syntax is needed to placate it so that you can
write:

  (define-public python2-rsvg
    (python2-gnome-desktop-component
      "rsvg"
      (synopsis "Python bindings to librsvg")
      (description "This module contains bindings allowing the use of
librsvg in Python.")))

So let=E2=80=99s say:

  (define-syntax python2-gnome-desktop-component
    (syntax-rules (synopsis description)
      ((_ component (synopsis synopsis*) (description description*))
       (%python2-gnome-desktop-component component synopsis*
                                         description*))))

Where =E2=80=98%python2-gnome-desktop-component=E2=80=99 is the new name of=
 the
procedure that this patch calls =E2=80=98python2-gnome-desktop-component=E2=
=80=99.

Really a hack, but hey, such is life.  ;-)

> From ba6cbc73f4ff3f1f5fc8e4ca26e867dc85291bd1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 19 Apr 2015 18:59:01 +0200
> Subject: [PATCH 2/2] gnu: Add python2-gnomekeyring.
>
> * gnu/packages/gnome.scm (python2-gnomekeyring): New variable.

OK.

Thanks,
Ludo=E2=80=99.