From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add Ardour 4.
Date: Thu, 23 Apr 2015 22:29:33 +0200
Message-ID: <878udid1w2.fsf@gnu.org>
References: <87vbgq1th0.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YlNkj-0006xh-1p
	for guix-devel@gnu.org; Thu, 23 Apr 2015 16:29:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YlNke-0005sW-A0
	for guix-devel@gnu.org; Thu, 23 Apr 2015 16:29:40 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53643)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YlNke-0005sS-7C
	for guix-devel@gnu.org; Thu, 23 Apr 2015 16:29:36 -0400
In-Reply-To: <87vbgq1th0.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Mon, 20 Apr 2015 21:37:47 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> From a72f8aabeba004067c1acb48ceebbd3c0e1fbdd8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 20 Apr 2015 21:36:17 +0200
> Subject: [PATCH] gnu: Add Ardour 4.
>
> * gnu/packages/audio.scm (ardour-4): New variable.

[...]

> +              (snippet
> +               '(call-with-output-file
> +                    "libs/ardour/revision.cc"
> +                  (lambda (port)
> +                    (format port "#include \"ardour/revision.h\"
> +namespace ARDOUR { const char* revision =3D \"4.0\" ; }"))))

Could you add a comment to explain this?

Otherwise LGTM, thanks!

Ludo=E2=80=99.