From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add markdown.
Date: Fri, 01 May 2015 22:33:06 +0200
Message-ID: <878ud89gxp.fsf@gnu.org>
References: <87egn1jpt0.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YoHcW-0002Gr-QJ
	for Guix-devel@gnu.org; Fri, 01 May 2015 16:33:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YoHcS-0006Rr-Ql
	for Guix-devel@gnu.org; Fri, 01 May 2015 16:33:12 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42220)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YoHcS-0006Re-OH
	for Guix-devel@gnu.org; Fri, 01 May 2015 16:33:08 -0400
In-Reply-To: <87egn1jpt0.fsf@openmailbox.org> (Mathieu Lirzin's message of
	"Thu, 30 Apr 2015 22:59:07 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: Guix-devel <Guix-devel@gnu.org>

Hi, Mathieu!

Mathieu Lirzin <mthl@openmailbox.org> skribis:

> From eec846d938b35b7a286660257d4f878723ad9da7 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Thu, 30 Apr 2015 22:26:57 +0200
> Subject: [PATCH] gnu: Add markdown.
>
> * gnu/packages/textutils.scm (markdown): New variable.

LGTM!  Some comments below:

> +         (use-modules (guix build utils))
> +         (let ((source (assoc-ref %build-inputs "source"))
> +               (out    (assoc-ref %outputs "out"))
> +               (unzip  (string-append (assoc-ref %build-inputs "unzip")
> +                                     "/bin/unzip")))
> +           (mkdir-p out)
> +           (with-directory-excursion out
> +             (system* unzip source)
> +             (mkdir "bin")
> +             (mkdir-p "share/doc")
> +             (rename-file  "Markdown_1.0.1/Markdown.pl" "bin/markdown")

I suspect you also need a call like:

  (patch-shebang "bin/markdown"
                 (list (string-append (assoc-ref %build-inputs "perl")
                                      "/bin")))

so that the #! line in bin/markdown refers to the right Perl.

> +    (license license:non-copyleft)))

=E2=80=98non-copyleft=E2=80=99 is a procedure so it should be:

  (license (license:non-copyleft "http://url-of-the-license-text"))

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.