From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/03: gnu: mozjs: Mark as unsupported on mips64el-linux.
Date: Wed, 06 May 2015 21:55:51 +0200
Message-ID: <878ud1scoo.fsf@gnu.org>
References: <20150505200559.14816.34558@vcs.savannah.gnu.org>
	<E1Ypj6O-0003rt-13@vcs.savannah.gnu.org> <874mnpya3z.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55471)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yq5QF-0003St-UM
	for guix-devel@gnu.org; Wed, 06 May 2015 15:56:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yq5QB-0004d9-3X
	for guix-devel@gnu.org; Wed, 06 May 2015 15:55:59 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60923)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yq5QB-0004d5-0m
	for guix-devel@gnu.org; Wed, 06 May 2015 15:55:55 -0400
In-Reply-To: <874mnpya3z.fsf@netris.org> (Mark H. Weaver's message of "Wed, 06
	May 2015 11:54:56 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 4bfeb0ca74fca75febe62b8e059b0c5a6ddd622f
>> Author: Ludovic Court=C3=A8s <ludo@gnu.org>
>> Date:   Tue May 5 21:39:18 2015 +0200
>>
>>     gnu: mozjs: Mark as unsupported on mips64el-linux.
>
> [...]
>
>> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>> index 522404f..8031a6c 100644
>> --- a/gnu/packages/gnuzilla.scm
>> +++ b/gnu/packages/gnuzilla.scm
>> @@ -85,7 +85,12 @@
>>      (synopsis "Mozilla javascript engine")
>>      (description "SpiderMonkey is Mozilla's JavaScript engine written
>>  in C/C++.")
>> -    (license license:mpl2.0))) ; and others for some files
>> +    (license license:mpl2.0)                      ;and others for some =
files
>> +
>> +    ;; On mips64el, this fails to build with several "control reaches e=
nd of
>> +    ;; non-void function" errors (see
>> +    ;; <http://hydra.gnu.org/build/407741/nixlog/3/raw>.)
>> +    (supported-systems (delete "mips64el-linux" %supported-systems))))
>
> In general, I would prefer not to mark packages as unsupported on a
> platform unless there is good reason to believe that the problems would
> be very difficult to resolve.

For me the reasoning was that if it doesn=E2=80=99t even build, then it=E2=
=80=99s
effectively unsupported upstream, but...

> In this case, Debian contains builds of mozjs for MIPS, and MIPS is
> supported by the Mozilla project.  For example, see:
>
>   https://bugzilla.mozilla.org/show_bug.cgi?id=3D902818
>
> where a mozjs bug is reported on MIPS (N32 ABI) and later fixed by
> upstream.

... I admit I had not done this research, and this is indeed
encouraging.

> Furthermore, mozjs is an important package.  polkit depends on mozjs,
> and several important GNOME components depend on polkit, so without
> mozjs we cannot have GNOME on MIPS.
>
> So, I would prefer to revert this commit.  What do you think?

OK, fine with me.  Now to find the upstream patch that fixes the issue...

Sorry for the inconvenience!

Ludo=E2=80=99.