unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add setBfree.
Date: Tue, 23 Jun 2015 14:53:22 +0200	[thread overview]
Message-ID: <878uba7fi5.fsf@gnu.org> (raw)
In-Reply-To: <87a8vxhvp5.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 18 Jun 2015 17:39:50 +0200")

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 00bd892e00e2f8d1261f4fffaf2a9ba31d5961e8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 18 Jun 2015 17:36:12 +0200
> Subject: [PATCH 1/2] gnu: ftgl: Propagate "freetype".
>
> * gnu/packages/gl.scm (ftgl)[inputs,propagated-inputs]: Move "freetype" from
>   "inputs" to "propagated-inputs".

[...]

> +    (propagated-inputs `(("freetype" ,freetype)))

Please explain the reason (Requires.private) in a comment above.

OK with this change.

> From 0110a38d7c1fcf47ffc5691f97966addd379f50c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 18 Jun 2015 17:37:47 +0200
> Subject: [PATCH 2/2] gnu: Add setBfree.
>
> * gnu/packages/audio.scm (setbfree): New variable.

LGTM!

Perhaps it would be more appropriate to have it in music.scm, no?

Thanks,
Ludo’.

  reply	other threads:[~2015-06-23 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 15:39 [PATCH] Add setBfree Ricardo Wurmus
2015-06-23 12:53 ` Ludovic Courtès [this message]
2015-06-23 17:55   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878uba7fi5.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).