From: Alex Kost <alezost@gmail.com>
To: Eric Dvorsak <yenda1@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] python2-ansible, python-ccm and dependencies
Date: Sat, 25 Jul 2015 12:28:18 +0300 [thread overview]
Message-ID: <878ua437t9.fsf@gmail.com> (raw)
In-Reply-To: <CAC9VnsKE1L-XaWmoNA2KjPC1KJ6HDEP25PrSdkBh=BSAFoOa2g@mail.gmail.com> (Eric Dvorsak's message of "Fri, 24 Jul 2015 18:21:17 +0200")
Eric Dvorsak (2015-07-24 19:21 +0300) wrote:
> I added the following package definitions to python.scm :
>
> - python2-ansible
> - python-passlib
> - python-py-bcrypt
> - python-paramiko
> - python-httplib2
> - python-ecdsa
> - python-ccm
>
> This is my first commit ever so if I did something wrong or missed a
> step in the process please let me know so I can improve for the next
> ones.
>
> Eric Dvorsak.
Hello and welcome! We prefer a single patch per package and the commit
messages should look like this:
--8<---------------cut here---------------start------------->8---
gnu: Add python2-ansible.
* gnu/packages/python.scm (python2-ansible): New variable.
--8<---------------cut here---------------end--------------->8---
See also other python commits.
And some quick notes:
> + (home-page "http://ansible.com/")
> + (synopsis "Radically simple IT automation")
> + (description "Radically simple IT automation")
Please, add periods in the end of descriptions. And usually
descriptions should be more verbose than synopses.
> + (license gpl3)))
'gpl3+'. 'gpl3' shouldn't even work in this module.
> + (home-page "http://passlib.googlecode.com")
This page says the project has moved. Perhaps
<https://pythonhosted.org/passlib/>?
> + (synopsis
> + "Comprehensive password hashing framework supporting over 30 schemes")
> + (description
> + "Comprehensive password hashing framework supporting over 30 schemes")
> + (license bsd-3))
> + )
(license bsd-3)))
Please do not put a single parenthesis on a separate line.
> +(define-public python-paramiko
> + (package
> + (name "python-paramiko")
> + (version "1.15.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://pypi.python.org/packages/source/p/paramiko/paramiko-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "0mbfzm9zlrz6mla9xakrm8wkll3x035f9rj3c5pbgjzfldqscmjg"))))
> + (build-system python-build-system)
> + (inputs
> + `(("python-ecdsa" ,python-ecdsa)
> + ("python-pycrypto" ,python-pycrypto)
> + ("python-setuptools" ,python-setuptools)))
> + (propagated-inputs
> + `(("python2-pycrypto" ,python2-pycrypto)))
Did you mean "python-pycrypto" (not "python2-pycrypto")?
--
Alex
next prev parent reply other threads:[~2015-07-25 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 16:21 [PATCH] python2-ansible, python-ccm and dependencies Eric Dvorsak
2015-07-25 9:28 ` Alex Kost [this message]
2015-07-25 10:07 ` Ricardo Wurmus
2015-07-25 19:58 ` Eric Dvorsak
2015-07-26 9:56 ` Alex Kost
2015-07-26 12:05 ` Eric Dvorsak
2015-07-29 9:51 ` Alex Kost
2015-07-31 8:06 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ua437t9.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=yenda1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).