From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [v2 1/1] gnu: Add peg-markdown. Date: Sun, 29 Nov 2015 11:21:33 +0100 Message-ID: <878u5hp0lu.fsf@gnu.org> References: <91abb64a6b8279ea62bcefff711586f790c83734.1448746196.git.leo@famulari.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2z6x-0002Gj-HL for guix-devel@gnu.org; Sun, 29 Nov 2015 05:21:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2z6u-0004Tc-D1 for guix-devel@gnu.org; Sun, 29 Nov 2015 05:21:39 -0500 In-Reply-To: <91abb64a6b8279ea62bcefff711586f790c83734.1448746196.git.leo@famulari.name> (Leo Famulari's message of "Sat, 28 Nov 2015 16:32:01 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > * gnu/packages/markdown.scm (peg-markdown): New variable. [...] > + ;; The Makefile offers a memory leak test using > + ;; Valgrind. > + (add-after 'check 'leak-check > + (lambda _ > + (zero? (system* "make" "leak-check")))) The opening parenthesis can be aligned below the =E2=80=98d=E2=80=99 of =E2= =80=98add-after=E2=80=99. > + (replace > + 'install > + (lambda* (#:key outputs #:allow-other-keys) Ditto, with =E2=80=98install=E2=80=99 moved to the previous line. > + ;; The Makefile does not check if the output paths= exist. > + (let* ((out (assoc-ref %outputs "out")) > + (bin (string-append out "/bin")) > + (doc (string-append out "/share/man/man1"))) > + (mkdir-p bin) > + ;; The top-level Makefile does not have an insta= ll > + ;; target, so we have to do this manually. > + (zero? > + (system* "make" "-C" "peg-0.1.4" > + (string-append "PREFIX=3D" %output) > + "CC=3Dgcc" "install")) > + ;; The Makefile does not install the manpage. > + (install-file "peg-0.1.4/peg.1" doc) > + ;; The manpage applies to both peg and leg. > + (symlink > + (string-append doc "/peg.1") > + (string-append doc "/leg.1")) > + #t)))))) The return value of =E2=80=98zero?=E2=80=99 is ignored here. To address this and clarify the code, what about making the symlink-manpage thing a separate phase, added after =E2=80=98install=E2=80= =99? > + (synopsis "Implementation of markdown in C, using a PEG grammar") Capitalize =E2=80=9CMarkdown=E2=80=9D (?); I think it=E2=80=99s fine to rem= ove =E2=80=9Cusing a PEG grammar=E2=80=9D, which is more of an implementation detail and is explaine= d in the description. > + (description "This is an implementation of John Gruber's markdown in= C. It > +uses a parsing expression grammar (PEG) to define the syntax. This shou= ld allow Make sure lines are below 80 chars. Could you send an updated patch? Thanks, Ludo=E2=80=99.