From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/6] emacs: Find packages in system profiles.
Date: Tue, 12 Jan 2016 21:28:55 +0100 [thread overview]
Message-ID: <878u3ubkzc.fsf@gnu.org> (raw)
In-Reply-To: <1452419630-4399-4-git-send-email-alezost@gmail.com> (Alex Kost's message of "Sun, 10 Jan 2016 12:53:47 +0300")
[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]
Alex Kost <alezost@gmail.com> skribis:
> For a usual profile, packages are placed in a profile directory itself,
> but for a system profile, packages are placed in 'profile'
> sub-directory. So we need to do some special cases for system profiles
> to find packages there as well.
>
> * emacs/guix-base.el (guix-packages-profile): New procedure.
> (guix-manifest-file): Use it. Add optional 'system?' argument.
> * emacs/guix-ui-generation.el (guix-system-generation?)
> (guix-generation-current-packages-profile): New procedures.
> (guix-generation-packages, guix-generation-insert-packages)
> (guix-generation-packages-buffer): Add optional 'system?' argument.
> (guix-profile-generation-manifest-file)
> (guix-profile-generation-packages-buffer): Adjust accordingly.
> * emacs/guix-main.scm (generation-package-specifications+paths): Rename to...
> (profile->specifications+paths): ... this. Use a single 'profile' argument.
[...]
> +(defun guix-packages-profile (profile &optional generation system?)
> + "Return a directory where packages are installed for the
> +PROFILE's GENERATION.
> +
> +If SYSTEM? is non-nil, then PROFILE is considered to be a system
> +profile. Unlike usual profiles, for a system profile, packages
> +are placed in 'profile' subdirectory."
> + (let ((profile (if generation
> + (guix-generation-file profile generation)
> + profile)))
> + (if system?
> + (expand-file-name "profile" profile)
> + profile)))
It seems you’re calling /run/current-system the system profile, which
leads to the ‘system?’ Boolean here, but the system profile really is
/run/current-system/profile.
I had overlooked it, but wouldn’t it be easier if patch #2 did:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 118 bytes --]
+(defvar guix-system-profile
+ (concat guix-config-state-directory "/profiles/system/profile")
+ "System profile.")
[-- Attachment #3: Type: text/plain, Size: 17 bytes --]
?
Ludo’.
next prev parent reply other threads:[~2016-01-12 20:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 9:53 [PATCH 0/6] emacs: Add "M-x guix-system-generations" Alex Kost
2016-01-10 9:53 ` [PATCH 1/6] guix system: Export <boot-parameters> accessors Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-13 20:44 ` Alex Kost
2016-01-13 22:33 ` Ludovic Courtès
2016-01-14 8:34 ` Alex Kost
2016-01-14 13:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 2/6] emacs: profiles: Add 'guix-system-profile' Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 3/6] emacs: Find packages in system profiles Alex Kost
2016-01-12 20:28 ` Ludovic Courtès [this message]
2016-01-13 20:45 ` Alex Kost
2016-01-13 22:42 ` Ludovic Courtès
2016-01-14 8:38 ` Alex Kost
2016-01-14 13:27 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 4/6] emacs: Replace 'generation-diff' search with 'profile-diff' Alex Kost
2016-01-12 20:29 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 5/6] emacs: Remove 'generation' search type Alex Kost
2016-01-12 20:31 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 6/6] emacs: Add interface for system generations Alex Kost
2016-01-12 20:35 ` Ludovic Courtès
2016-01-13 20:56 ` Alex Kost
2016-01-13 22:44 ` Ludovic Courtès
2016-01-12 20:23 ` [PATCH 0/6] emacs: Add "M-x guix-system-generations" Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u3ubkzc.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).