Re: [PATCH] gnu: Add laby.

[Jan Nieuwenhuizen <janneke@gnu.org>]

Andreas Enge writes:

> Very good, I pushed the first two. Concerning the commit message, it should
> read "gnu: ocaml: ..." in case a package is modified.

Ah okay...and Yay, thanks!

>> Subject: [PATCH 3/3] gnu: Add laby.
>> * gnu/packages/patches/laby-make-install.patch: New file.
>> * gnu/packages/patches/laby-make-png.patch: New file.
>> * gnu-system.am (dist_patch_DATA): Add them.
>> * gnu/packages/games.scm (laby): New variable.
>
> Here I would not use a patch. The policy is not totally clear (and not
> written up), but if an additional phase for installation is needed, I
> would do it in a custom phase on the scheme side instead of patching the
> makefile. See, for instance, the tinyxml package in xml.scm.

Yes, I see.  Good to know, thanks.

> Maybe it would also warrant an upstream bug report?

Yes, I have sent the patches upstream.

> Similarly for the make-png patch. Is this an upstream bug?

I think it's a problem with Guix's ocaml or gtk not rendering svg
images; so I wanted to first `see if png works' and then figure out
what's going on...So this could be temporary, depending on the
availability of svg rendering, not sure what to do here.

So...please advise.

Greetings,
Jan

> PS: The game starts and shows the maze, it looks quite nice!

:-)

Laby looks for programming languages installed and offer only those that
are available.  So while it does not depend on guile, gcc, ocaml etc...,
those packages make it more functional.

> PPS: You do not happen to use unison? I think your previous patches would
>      allow to build it with gtk support, and unlike me, you seem to know
>      what you are doing...

No, I have used SparkleShare until it became obvious there won't be a
headless version and I reverted to plain git.  I'll have a look.  Does
it use git for a backend?

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl