From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Fix arandr. Date: Sat, 27 Feb 2016 16:28:45 +0100 Message-ID: <878u26dvf6.fsf@elephly.net> References: <87povie7oi.fsf@elephly.net> <87io1athx7.fsf@netris.org> <87d1ridzzn.fsf@elephly.net> <87wppqrz9j.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZgnj-0002Co-Oz for guix-devel@gnu.org; Sat, 27 Feb 2016 10:29:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZgnf-0005Sg-OQ for guix-devel@gnu.org; Sat, 27 Feb 2016 10:28:59 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:25292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZgnf-0005SZ-GG for guix-devel@gnu.org; Sat, 27 Feb 2016 10:28:55 -0500 In-reply-to: <87wppqrz9j.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel Mark H Weaver writes: > Ricardo Wurmus writes: > >> Mark H Weaver writes: >> >>> Ricardo Wurmus writes: >>> >>>> arandr doesn’t work as it needs “xrandr” at runtime. I tried to patch >>>> the sources to replace the path to the “xrandr” binary with a full store >>>> item path, but this wasn’t quite as pretty as I hoped as the arandr >>>> sources don’t define the path once but directly assemble command line >>>> strings in several places. Propagating “xrandr” is the cleaner solution >>>> in my opinion. >>> >>> How about making a wrapper for arandr that sets PATH to find xrandr? >> >> Patch attached: >> >> From 28f0dc229bdba3e53bd101e5acf5e93e4ff7907e Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Sat, 27 Feb 2016 12:00:20 +0100 >> Subject: [PATCH] gnu: arandr: Add "xrandr" to inputs. >> >> * gnu/packages/xdisorg.scm (arandr)[inputs]: Add "xrandr". >> [arguments]: Add build phase "make-xrandr-available" to ensure "xrandr" >> executable is found at runtime. > > Looks good to me. Please push. Pushed as b951e26. ~~ Ricardo