From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add gnome-calendar. Date: Wed, 11 May 2016 12:07:44 +0200 Message-ID: <878tzgrjpr.fsf@elephly.net> References: <20160510002451.0f51f64d@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0R3b-0002bm-O9 for guix-devel@gnu.org; Wed, 11 May 2016 06:07:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0R3X-0005fh-K4 for guix-devel@gnu.org; Wed, 11 May 2016 06:07:55 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0R3X-0005fH-AP for guix-devel@gnu.org; Wed, 11 May 2016 06:07:51 -0400 In-reply-to: <20160510002451.0f51f64d@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Yamashita Cc: guix-devel@gnu.org Hi, thank you for the patch! > Note that this package is nonfunctional without first applying the > libical patch I sent earlier. > From 29033622d9490d299d2409b73f9e21862ca939ec Mon Sep 17 00:00:00 2001 > From: Kei Yamashita > Date: Tue, 10 May 2016 00:16:46 -0400 > Subject: [PATCH] gnu: Add gnome-calendar. > * gnu/packages/gnome.scm (gnome-calendar): New variable. > --- > gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 0fd1d5b..0274f20 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -4995,3 +4995,32 @@ specified duration and save it as a GIF encoded animated image file.") > "Libzapojit is a GLib-based library for accessing online service APIs of > Microsoft SkyDrive and Hotmail, using their REST protocols.") > (license license:lgpl2.1+))) > + > +(define-public gnome-calendar > + (package > + (name "gnome-calendar") > + (version "3.18.3") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "0xcmhzz3lfy9sx2ff2krjdhcrhmapgn8nssbwlcfrb15jw2pcnyv")))) > + (build-system glib-or-gtk-build-system) > + (native-inputs > + `(("intltool" ,intltool) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("bdb" ,bdb) > + ("desktop-file-utils" ,desktop-file-utils) > + ("evolution-data-server" ,evolution-data-server) > + ("gnome-online-accounts" ,gnome-online-accounts))) > + (home-page "https://wiki.gnome.org/Apps/Calendar") > + (synopsis "Calendar application designed to fit GNOME desktop") I think “to fit *the* GNOME desktop” might be better. > + (description > + "GNOME Calendar is a simple and beautiful calendar application designed to > +perfectly fit the GNOME desktop. By reusing the components which the GNOME > +desktop is build on, Calendar nicely integrates with the GNOME ecosystem.") > + (license license:gpl3+))) > -- > 2.7.4 The description is a bit shallow, in my opinion. Both sentences say that it fits the GNOME deskop, and part of the first sentence says it’s “beautiful”. I don’t have strong objections to this description, but I think we could do better. (I also don’t really like the word “ecosystem” in this context.) Otherwise this looks very good to me. (NOTE: I haven’t built the package myself.) ~~ Ricardo