From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] entr-3.5
Date: Sun, 15 May 2016 21:50:31 +0200
Message-ID: <878tzb2j94.fsf@inria.fr>
References: <87wpn0ofn8.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<87wpn0sh26.fsf@gnu.org>
	<87y47gy0l3.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b22RV-0001ba-EO
	for guix-devel@gnu.org; Sun, 15 May 2016 16:15:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b22RR-0004cH-Hh
	for guix-devel@gnu.org; Sun, 15 May 2016 16:15:13 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:40732)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1b22RR-0004bp-Ar
	for guix-devel@gnu.org; Sun, 15 May 2016 16:15:09 -0400
In-Reply-To: <87y47gy0l3.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	(Matthew Jordan's message of "Wed, 11 May 2016 13:19:04 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Matthew Jordan <matthewjordandevops@yandex.com>
Cc: Guix-devel <guix-devel@gnu.org>

Hello!

Matthew Jordan <matthewjordandevops@yandex.com> skribis:

> Thank you for the welcome Ludovic Court=C3=A8s. I just have a couple of
> questions.
>
>>   3. Added the file to gnu/local.mk.
>
> Is this file to be updated when a new source file is added?

Yes.

>>   4. Added a ChangeLog-style commit log.
>
> Is there a specific reference/manual on the "ChangeLog-style" I could rev=
iew?

The manual contains references to the GNU Coding Standards, which
explain it in more detail:

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Otherwise, it=E2=80=99s a good idea to look at the output of =E2=80=98git l=
og=E2=80=99 and to
mimic what others do.  :-)

>>   2. Added a =E2=80=98remove-fhs-file-names=E2=80=99 phase to remove har=
d-coded
>>      references to /bin/cat and /usr/bin/clear.
>
> And is =E2=80=98remove-fhs-file-names=E2=80=99 a custom phase? If not, wh=
ich source file
> contains the available phases?

No, it=E2=80=99s a phase I added specifically to this package.  See
gnu/packages/entr.scm.

HTH!

Ludo=E2=80=99.