From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add emacs-clojure-mode Date: Thu, 19 May 2016 11:54:47 +0300 Message-ID: <878tz61l7s.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3JjF-0007kt-6u for guix-devel@gnu.org; Thu, 19 May 2016 04:54:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3JjD-0008BM-RC for guix-devel@gnu.org; Thu, 19 May 2016 04:54:49 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3JjD-0008B3-J0 for guix-devel@gnu.org; Thu, 19 May 2016 04:54:47 -0400 Received: by mail-lf0-x244.google.com with SMTP id y84so4979260lfc.3 for ; Thu, 19 May 2016 01:54:47 -0700 (PDT) In-Reply-To: (catonano@gmail.com's message of "Wed, 18 May 2016 17:09:43 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Catonano Cc: guix-devel@gnu.org Catonano (2016-05-18 18:09 +0300) wrote: > From 6dc8470baf3493a93da3e3358136e5c9860d4e3a Mon Sep 17 00:00:00 2001 > From: humanitiesNerd > Date: Wed, 18 May 2016 15:41:47 +0200 > Subject: gnu: Add emacs-clojure-mode ^ This is a nitpick of course, but we put a period here... > * gnu/packages/emacs.scm (emacs-clojure-mode): New variable ^ ... and here. > --- > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 32ed722..fb07bc7 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -1612,3 +1612,41 @@ It is built on top of the custom theme support in Emacs 24 or later.") > (license license:gpl3+))) > > > +(define-public emacs-clojure-mode > + (package > + (name "emacs-clojure-mode") > + (version "5.3.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/clojure-emacs/clojure-mode.git") > + (commit "8ef7127da214cb7fd4b47fc943462f2a8bfb8f85"))) Is there a reason to use 'git-fetch'? I think a usual 'url-fetch' is fine as there is: . > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "1x7nl5wzcah9hnlj5jfd3y5604w60zcqcw1nn6vw335c2vzzissj")))) > + (build-system emacs-build-system) > + (home-page "http://github.com/clojure-emacs/clojure-mode") > + (synopsis "Major mode for Clojure code") > + (description > + "Provides font-lock, indentation, navigation and basic refactoring for the We use full sentences for descriptions, like this: "This emacs package provides ..." > +Clojure programming language (http://clojure.org). Since we use texinfo to format descriptions, it is better to write: @uref{http://clojure.org, Clojure programming language} > + > +Using clojure-mode with paredit or smartparens is highly recommended. I think this description is too verbose. I would remove all the text below. > + > +Here are some example configurations: > + > + ;; require or autoload paredit-mode > + (add-hook 'clojure-mode-hook #'paredit-mode) > + > + ;; require or autoload smartparens > + (add-hook 'clojure-mode-hook #'smartparens-strict-mode) > + > +See inf-clojure (http://github.com/clojure-emacs/inf-clojure) for > +basic interaction with Clojure subprocesses. > + > +See CIDER (http://github.com/clojure-emacs/cider) for > +better interaction with subprocesses via nREPL. > +") > + (license license:gpl3+))) -- Alex