From mboxrd@z Thu Jan 1 00:00:00 1970 From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Subject: Re: [PATCH] gnu: Add higan. Date: Tue, 07 Jun 2016 18:28:59 +0300 Message-ID: <878tyh81c4.fsf@T420.taylan> References: <87fustalcn.fsf@T420.taylan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIwF-0002VH-2F for guix-devel@gnu.org; Tue, 07 Jun 2016 11:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAIwA-0007Em-NF for guix-devel@gnu.org; Tue, 07 Jun 2016 11:29:05 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:36714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIwA-0007Ef-CR for guix-devel@gnu.org; Tue, 07 Jun 2016 11:29:02 -0400 Received: by mail-wm0-x244.google.com with SMTP id m124so24011568wme.3 for ; Tue, 07 Jun 2016 08:29:02 -0700 (PDT) Received: from T420.taylan ([78.179.63.17]) by smtp.gmail.com with ESMTPSA id h8sm816307wjg.9.2016.06.07.08.28.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jun 2016 08:29:00 -0700 (PDT) In-Reply-To: <87fustalcn.fsf@T420.taylan> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sat, 04 Jun 2016 02:44:40 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org If there are no comments, I'll just push this soon, and issues can be fixed later; at least it builds and runs fine. :-) Taylan taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes: > Some things to note about this package & questions: > > - There's no official VCS repo and the author doesn't want automated > tools to download files from his homepage; there's an unofficial git > repo at GitLab but I found it unsuitable so I'm hosting the sources > specifically for Guix at GitHub now: > > https://github.com/TaylanUB/higan > > Is this OK, or is there a place we can upload the original source > bundle for Guix to download from? > > - I forgot if there's a guideline for this: the release versions are > called 'v097', 'v098' etc. with always a 'v' in front. Should that > 'v' appear in the version field of the package or should it be > stripped? > > - As seems to be tradition among emulator developers, the build system > and the program's handling of the file system are a big pile of poo, > so: > > * Is it principally OK to reuse the standard `build' and `install' > phase procedures a second time, just with the CWD changed, as I do > here? > > * The program insists on looking in ~/.local/share for some data files > that are actually installed in $prefix/share; does my strategy here > look OK, in that I wrap the executable to copy the data files into > ~/.local/share every time the program is run? > > Thank you! > > Taylan > > > From 707e8fc3c2ba1293693168b1d7a34e6000671158 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?= =3D > > Date: Sun, 1 Nov 2015 20:45:09 +0100 > Subject: [PATCH] gnu: Add higan. > > * gnu/packages/games.scm (higan): New variable. > --- > gnu/packages/games.scm | 92 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 92 insertions(+) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index e552d09..57f8907 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -2243,3 +2243,95 @@ Red Eclipse provides fast paced and accessible gam= eplay.") > license:cc-by-sa3.0 > license:cc-by3.0 > license:cc0))))) > + > +(define-public higan > + (package > + (name "higan") > + (version "v098") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/TaylanUB/higan/archive/" version ".tar.= gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 "12snxrk8wa94x3l69qcimgm0xc22zjgf7vzhckp2lzyfbf27950v"))= )) > + (build-system gnu-build-system) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("alsa-lib" ,alsa-lib) > + ("ao" ,ao) > + ("eudev" ,eudev) > + ("gtk+" ,gtk+-2) > + ("gtksourceview-2" ,gtksourceview-2) > + ("libxv" ,libxv) > + ("mesa" ,mesa) > + ("openal" ,openal) > + ("pulseaudio" ,pulseaudio) > + ("sdl" ,sdl))) > + (arguments > + '(#:phases > + (let ((build-phase (assoc-ref %standard-phases 'build)) > + (install-phase (assoc-ref %standard-phases 'install))) > + (modify-phases %standard-phases > + ;; The higan build system has no configure phase. > + (delete 'configure) > + (add-before 'build 'chdir-to-higan > + (lambda _ > + (chdir "higan"))) > + (add-before 'install 'create-/share/applications > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + ;; It seems the author forgot to do this in the Makefil= e. > + (mkdir-p (string-append out "/share/applications"))))) > + (add-after 'install 'chdir-to-icarus > + (lambda _ > + (chdir "../icarus"))) > + (add-after 'chdir-to-icarus 'build-icarus build-phase) > + (add-after 'build-icarus 'install-icarus install-phase) > + (add-after 'install-icarus 'wrap-higan-executable > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (higan (string-append bin "/higan")) > + (higan-original (string-append higan "-original")) > + (bash (string-append (assoc-ref inputs "bash") > + "/bin/bash")) > + (coreutils (assoc-ref inputs "coreutils")) > + (mkdir (string-append coreutils "/bin/mkdir")) > + (cp (string-append coreutils "/bin/cp"))) > + ;; First, have the executable make sure ~/.local/share/= higan > + ;; contains up to date files. Higan insists on looking= there > + ;; for these data files. > + (rename-file higan higan-original) > + (with-output-to-file higan > + (lambda () > + (display > + (string-append > + "#!" bash "\n" > + ;; higan doesn't respect $XDG_DATA_HOME > + mkdir " -p ~/.local/share\n" > + cp " -r " out "/share/higan ~/.local/share\n" > + "exec " higan-original)))) > + (chmod higan #o555) > + ;; Second, make sure higan will find icarus in PATH. > + (wrap-program higan > + `("PATH" ":" prefix (,bin)))))))) > + #:make-flags > + (list "compiler=3Dg++" > + (string-append "prefix=3D" (assoc-ref %outputs "out"))) > + ;; There is no test suite. > + #:tests? #f)) > + (home-page "http://byuu.org/emulation/higan/") > + (synopsis "Nintendo multi-system emulator") > + (description > + "higan (formerly bsnes) is an emulator for multiple Nintendo video = game > +consoles, including the Nintendo Entertainment System (NES/Famicom), Sup= er > +Nintendo Entertainment System (SNES/Super Famicom), Game Boy, Game Boy > +Color (GBC), and Game Boy Advance (GBA). It also supports the subsystems > +Super Game Boy, BS-X Satellaview, and Sufami Turbo.") > + ;; As noted in these files among more: > + ;; - icarus/icarus.cpp > + ;; - higan/emulator/emulator.hpp > + (license license:gpl3)))