From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH]: gnu: Add guile-dbi.
Date: Mon, 20 Jun 2016 10:24:47 +0200
Message-ID: <878ty06ze8.fsf@gnu.org>
References: <87bn2yc3zu.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bEuVr-0003kV-DX
	for guix-devel@gnu.org; Mon, 20 Jun 2016 04:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bEuVn-00035o-6U
	for guix-devel@gnu.org; Mon, 20 Jun 2016 04:24:54 -0400
In-Reply-To: <87bn2yc3zu.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?=
	=?utf-8?B?cw==?= message of "Sat, 18 Jun 2016 16:09:41 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> From 8e73c3e1a798b134e341c71c4b1c17d60956e3d5 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Fri, 17 Jun 2016 22:44:56 +0800
> Subject: [PATCH 1/2] gnu: Add guile-dbi.
>
> * gnu/packages/guile.scm (guile-dbi): New variable.

LGTM!

> From 87c3ef658e24035715b48606fb9ef24d55aaddfa Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Sat, 18 Jun 2016 15:49:36 +0800
> Subject: [PATCH 2/2] gnu: Add guile-dbd-sqlite3.
>
> * gnu/packages/guile.scm (guile-dbd-sqlite3): New variable.

LGTM.

> Unfortunately, Guile DBI loads its backends using `dlopen',
> so I have to set 'LD_LIBRARY_PATH' to '$guile-dbd-sqlite/lib'
> for loading it.

I don=E2=80=99t have any great ideas.

If it uses lt_dlopen, then we should recommend setting LTDL_LIBRARY_PATH
instead of LD_LIBRARY_PATH, which is a lesser evil.

Otherwise, we could also hard-code the file name of, say,
guile-dbd-sqlite in guile-dbi, such that there=E2=80=99s always at least one
backend available.

WDYT?

Thanks,
Ludo=E2=80=99.