From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 00/17] Emacs packages!
Date: Sat, 16 Jul 2016 17:31:18 +0200
Message-ID: <878tx1ioqh.fsf@elephly.net>
References: <20160712210514.21310-1-rekado@elephly.net>
	<878tx3x8fd.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bORYw-0001qp-GN
	for guix-devel@gnu.org; Sat, 16 Jul 2016 11:31:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bORYt-0005fT-7o
	for guix-devel@gnu.org; Sat, 16 Jul 2016 11:31:30 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bORYt-0005f4-0N
	for guix-devel@gnu.org; Sat, 16 Jul 2016 11:31:27 -0400
In-reply-to: <878tx3x8fd.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org


Alex Kost <alezost@gmail.com> writes:

> Ricardo Wurmus (2016-07-13 00:04 +0300) wrote:
>
>> Hi Guix,
>>
>> here are almost all of the remaining Emacs packages that I previously
>> installed via package.el.  I hope you find them useful!
>>
>> ~~ Ricardo
>>
>> Ricardo Wurmus (17):
>>   gnu: Add emacs-el-mock.
>>   gnu: Add emacs-espuds.
>>   gnu: Add emacs-expand-region.
>>   gnu: Add emacs-fill-column-indicator.
>>   gnu: Add emacs-znc.
>>   gnu: Add emacs-paren-face.
>>   gnu: Add emacs-page-break-lines.
>>   gnu: Add emacs-simple-httpd.
>>   gnu: Add emacs-skewer-mode.
>>   gnu: Add emacs-rich-minority.
>>   gnu: Add emacs-smart-mode-line.
>>   gnu: Add emacs-shut-up.
>>   gnu: Add emacs-undercover.
>>   gnu: Add emacs-shell-switcher.
>>   gnu: Add emacs-tagedit.
>>   gnu: Add emacs-perspective.
>>   gnu: Add emacs-solarized-theme.
>
> Overall, the packages look good to me, thanks!
>
> My main question is about adding to inputs libraries that are not needed
> for the packages themselves, as I wrote in the replies.

Thank you for the review.

I added inputs that are needed for the tests mostly because I didn’t
understand the error messages or warnings during the build phase.  I
wanted to avoid skipped files in the compilation process, so I added all
these development inputs like “espuds”.

It’s good to know I may leave them off.  Thanks for the helpful
comments.  I’ll update the patches and push them.

~~ Ricardo